Closed Bug 876179 Opened 11 years ago Closed 5 years ago

Intermittent test_webgl_debug_renderer_info.html | uncaught exception - NS_ERROR_FAILURE: Failure at chrome://mochitests/content/chrome/content/canvas/test/chrome/test_webgl_debug_renderer_info.html:35

Categories

(Core :: Graphics: CanvasWebGL, defect, P3)

Product:
Core
Component:
Graphics: CanvasWebGL
Platform:
x86
Windows 7
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: philor, Unassigned)

Details

(Keywords: intermittent-failure, Whiteboard: webgl-internal)

Attachments

(1 file)

Fix test time out if WebGL context creation fails due to black listing
7.37 KB, patch
jgilbert
: review-
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=23401499&tree=Mozilla-Central
Windows 7 32-bit mozilla-central pgo test mochitest-other on 2013-05-25 06:18:48 PDT for push 7a2f7a45819a
slave: t-w732-ix-070

06:22:33     INFO -  997 INFO TEST-START | chrome://mochitests/content/chrome/content/canvas/test/chrome/test_webgl_debug_renderer_info.html
06:22:33     INFO -  998 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/content/canvas/test/chrome/test_webgl_debug_renderer_info.html | uncaught exception - NS_ERROR_FAILURE: Failure at chrome://mochitests/content/chrome/content/canvas/test/chrome/test_webgl_debug_renderer_info.html:35
06:22:34     INFO -  999 INFO TEST-END | chrome://mochitests/content/chrome/content/canvas/test/chrome/test_webgl_debug_renderer_info.html | finished in 278ms
Whiteboard: webgl-internal
Seems that our test infrastructure black lists WebGL. So I made it robust to that.
Attachment #8532431 - Flags: review?(jgilbert)
Assignee: nobody → dglastonbury
Status: NEW → ASSIGNED
Comment on attachment 8532431 [details] [diff] [review]
Fix test time out if WebGL context creation fails due to black listing

Review of attachment 8532431 [details] [diff] [review]:
-----------------------------------------------------------------

I would prefer to not have tests worry about this. It seems better to me if we use `skip-if` in the mochitest manifests in these cases. Does that work here? `r?` me again if not.
Attachment #8532431 - Flags: review?(jgilbert) → review-
(In reply to Jeff Gilbert [:jgilbert] from comment #37)
> Comment on attachment 8532431 [details] [diff] [review]
> Fix test time out if WebGL context creation fails due to black listing
> 
> Review of attachment 8532431 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I would prefer to not have tests worry about this. It seems better to me if
> we use `skip-if` in the mochitest manifests in these cases. Does that work
> here? `r?` me again if not.

Can we do skip-if and check if webgl is going to be blacklisted? I don't know about our testing infra.

The issue appears to be that in the iframe test the message is never sent back to outer frame because gl is null and throws an exception. How about making the iframe test always send the message back to the outer frame, by wrapping a try block around the test to catch the exception and report the error?
Flags: needinfo?(jgilbert)
Or we could force the creation of context with webgl.force-enabled pref?
No activity on this for over a year.
Assignee: dglastonbury → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(jgilbert)
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: