876187 - Reader Mode font size settings are too small

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Daniel]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130522 Firefox/24.0 (Nightly/Aurora)
Build ID: 20130522031027

Steps to reproduce:

On my 11" tablet the text fells too small even with the largest font size setting. The smallest setting is super tiny so perhaps we could increase the size of all steps?

Comment 1

[Aaron Train [:aaronmt]]

Can you attach a screenshot? Which 11" tablet and OS version?

Comment 2

[Ian Barlow (:ibarlow)]

I tend to agree -- perhaps we could drop the smallest size and replace it with a bigger one as the maximum size.  

Two screenshots on the current nightly, on a Nexus 10: 
Small: http://cl.ly/image/0H0y0Z0o452d
Large: http://cl.ly/image/3M1X171X2t2g

Comment 3

[Daniel]

Attachment: Screenshot largest font size

Comment 4

[Daniel]

Attachment: Screenshot Feedly

The largest font size is roughly the same as the text in the Feedly app, which I think is a good normal setting.

Comment 5

[Daniel]

I'm using an Asus Transformer TF300 (10" not 11" of course) with Android 4.2.1

Comment 6

[:Margaret Leibovic]

(In reply to Ian Barlow (:ibarlow) from comment #2)
> I tend to agree -- perhaps we could drop the smallest size and replace it
> with a bigger one as the maximum size.  

We can do that. This just involves changing the CSS styles for the different font sizes.

I did something similar in this changeset, which removed the smallest and largest options that we used to have:
https://hg.mozilla.org/mozilla-central/diff/0623dece2b89/mobile/android/themes/core/aboutReader.css

To fix this bug, we should shift the values for all of the .font-sizeX styles. We can use the font size rules we used to use for the largest size for the new largest size (if that makes sense).

Comment 7

[Sunny [:darkowlzz]]

Attachment: Increased the font-size of all the font-sizeX classes

Please see if the new font-sizes are good enough and also if there is anything else to be done.

Comment 8

[:Margaret Leibovic]

Comment on attachment 755203 [details] [diff] [review]
Increased the font-size of all the font-sizeX classes

Nice! This is perfect. Thanks for taking this on.

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a76f2a5ab3a0

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a76f2a5ab3a0