876194 - Layout crashtests 656130-2.html and 660451-1.html are the exact same file

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

I just noticed that these two crashtests are the exact same file:
  http://mxr.mozilla.org/mozilla-central/source/layout/generic/crashtests/656130-2.html
  http://mxr.mozilla.org/mozilla-central/source/layout/generic/crashtests/660451-1.html

$ md5sum layout/generic/crashtests/660451-1.html layout/generic/crashtests/656130-2.html 
2c56072e2efffe07a0abf60b1294583f  layout/generic/crashtests/660451-1.html
2c56072e2efffe07a0abf60b1294583f  layout/generic/crashtests/656130-2.html

So, it looks like we can remove one of them, and maybe we need to swap in a different crashtest, if there was something else that was supposed to be checked in, in one of these cases.

Comment 1

[(no longer active)]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> I just noticed that these two crashtests are the exact same file:
>  
> http://mxr.mozilla.org/mozilla-central/source/layout/generic/crashtests/
> 656130-2.html
>  
> http://mxr.mozilla.org/mozilla-central/source/layout/generic/crashtests/
> 660451-1.html
> 
> $ md5sum layout/generic/crashtests/660451-1.html
> layout/generic/crashtests/656130-2.html 
> 2c56072e2efffe07a0abf60b1294583f  layout/generic/crashtests/660451-1.html
> 2c56072e2efffe07a0abf60b1294583f  layout/generic/crashtests/656130-2.html

Wow!  :-)  How did you find out about this?

> So, it looks like we can remove one of them, and maybe we need to swap in a
> different crashtest, if there was something else that was supposed to be
> checked in, in one of these cases.

Nope, the original test cases were indeed duplicates.

I removed the former: https://hg.mozilla.org/integration/mozilla-inbound/rev/4bd2726de258

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #1)
> Wow!  :-)  How did you find out about this?

I checked in a patch that triggered an assertion in just those two tests, and I looked at the two tests. :)

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4bd2726de258