Closed Bug 876194 Opened 12 years ago Closed 12 years ago

Layout crashtests 656130-2.html and 660451-1.html are the exact same file

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla24

People

(Reporter: dholbert, Assigned: ehsan.akhgari)

References

Details

I just noticed that these two crashtests are the exact same file: http://mxr.mozilla.org/mozilla-central/source/layout/generic/crashtests/656130-2.html http://mxr.mozilla.org/mozilla-central/source/layout/generic/crashtests/660451-1.html $ md5sum layout/generic/crashtests/660451-1.html layout/generic/crashtests/656130-2.html 2c56072e2efffe07a0abf60b1294583f layout/generic/crashtests/660451-1.html 2c56072e2efffe07a0abf60b1294583f layout/generic/crashtests/656130-2.html So, it looks like we can remove one of them, and maybe we need to swap in a different crashtest, if there was something else that was supposed to be checked in, in one of these cases.
(In reply to Daniel Holbert [:dholbert] from comment #0) > I just noticed that these two crashtests are the exact same file: > > http://mxr.mozilla.org/mozilla-central/source/layout/generic/crashtests/ > 656130-2.html > > http://mxr.mozilla.org/mozilla-central/source/layout/generic/crashtests/ > 660451-1.html > > $ md5sum layout/generic/crashtests/660451-1.html > layout/generic/crashtests/656130-2.html > 2c56072e2efffe07a0abf60b1294583f layout/generic/crashtests/660451-1.html > 2c56072e2efffe07a0abf60b1294583f layout/generic/crashtests/656130-2.html Wow! :-) How did you find out about this? > So, it looks like we can remove one of them, and maybe we need to swap in a > different crashtest, if there was something else that was supposed to be > checked in, in one of these cases. Nope, the original test cases were indeed duplicates. I removed the former: https://hg.mozilla.org/integration/mozilla-inbound/rev/4bd2726de258
Assignee: nobody → ehsan
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #1) > Wow! :-) How did you find out about this? I checked in a patch that triggered an assertion in just those two tests, and I looked at the two tests. :)
https://hg.mozilla.org/mozilla-central/rev/4bd2726de258
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.