Remove the separator indentation in viewPickerPopup

RESOLVED FIXED in Thunderbird 24.0

Status

Thunderbird
Theme
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 24.0
All
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
+++ This bug was initially created as a clone of Bug #861933 +++

I'd say the indented menuitems are less desirable than the partially completed separators, so let's go with this patch for now.

But please file a follow-up bug to do something about those separators, if you haven't already.
(Assignee)

Comment 1

4 years ago
The indentation happens only on default theme, so put the rule in @media (-moz-windows-default-theme).

The original separator color is #E0E0E0. With ThreeDLightShadow we are using #E3E3E3. This should be close enough and not visible as they aren't mixed in this popup.
(Assignee)

Comment 2

4 years ago
Created attachment 754209 [details] [diff] [review]
patch

Oops, somehow the patch wasn't attached.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #754209 - Flags: ui-review?(mconley)
Attachment #754209 - Flags: review?(mconley)
(Assignee)

Comment 3

4 years ago
Created attachment 754210 [details]
screenshot for easier ui-r
(Assignee)

Updated

4 years ago
Keywords: checkin-needed

Comment 4

4 years ago
On Windows XP (without the patch) the separators are full width but the "Tags" and "Custom views" items are indented. Is that how it should be?
Comment on attachment 754209 [details] [diff] [review]
patch

Looks good! Thanks!
Attachment #754209 - Flags: ui-review?(mconley)
Attachment #754209 - Flags: ui-review+
Attachment #754209 - Flags: review?(mconley)
Attachment #754209 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/32140632beac
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.