Last Comment Bug 876222 - Remove the separator indentation in viewPickerPopup
: Remove the separator indentation in viewPickerPopup
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All Windows 7
-- normal (vote)
: Thunderbird 24.0
Assigned To: Richard Marti (:Paenglab)
Depends on: 861933
  Show dependency treegraph
Reported: 2013-05-26 01:26 PDT by Richard Marti (:Paenglab)
Modified: 2013-06-25 05:18 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch (1.09 KB, patch)
2013-05-26 01:42 PDT, Richard Marti (:Paenglab)
mconley: review+
mconley: ui‑review+
Details | Diff | Splinter Review
screenshot for easier ui-r (2.04 KB, image/png)
2013-05-26 01:43 PDT, Richard Marti (:Paenglab)
no flags Details

Description User image Richard Marti (:Paenglab) 2013-05-26 01:26:03 PDT
+++ This bug was initially created as a clone of Bug #861933 +++

I'd say the indented menuitems are less desirable than the partially completed separators, so let's go with this patch for now.

But please file a follow-up bug to do something about those separators, if you haven't already.
Comment 1 User image Richard Marti (:Paenglab) 2013-05-26 01:39:49 PDT
The indentation happens only on default theme, so put the rule in @media (-moz-windows-default-theme).

The original separator color is #E0E0E0. With ThreeDLightShadow we are using #E3E3E3. This should be close enough and not visible as they aren't mixed in this popup.
Comment 2 User image Richard Marti (:Paenglab) 2013-05-26 01:42:18 PDT
Created attachment 754209 [details] [diff] [review]

Oops, somehow the patch wasn't attached.
Comment 3 User image Richard Marti (:Paenglab) 2013-05-26 01:43:13 PDT
Created attachment 754210 [details]
screenshot for easier ui-r
Comment 4 User image :aceman 2013-05-29 03:11:17 PDT
On Windows XP (without the patch) the separators are full width but the "Tags" and "Custom views" items are indented. Is that how it should be?
Comment 5 User image Mike Conley (:mconley) 2013-06-02 19:09:39 PDT
Comment on attachment 754209 [details] [diff] [review]

Looks good! Thanks!
Comment 6 User image Ryan VanderMeulen [:RyanVM] 2013-06-03 05:41:04 PDT

Note You need to log in before you can comment on or make changes to this bug.