Scissor rect inconsistencies with OMTC / FPS display clipped

RESOLVED FIXED in mozilla24

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla24
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
When I set layers.offmainthreadcomposition.enabled and layers.acceleration.draw-fps to true, the FPS display sometimes doesn't show completely or at all, depending on the repainted region.

It seems that this is caused by the scissor rect which is set in CompositorOGL::DrawQuad.

Should DrawQuad clean up the scissor rect after itself? Or should the FPS display make sure that there's no scissor rect which can clip it? Or should DrawFPS disable GL_SCISSOR_TEST?

The same problem caused me to add Push/PopScissorRect in nsChildView::DrawWindowOverlay in bug 676241.
(Assignee)

Comment 1

5 years ago
Created attachment 754239 [details] [diff] [review]
patch A for discussion: correct scissor rect in DrawFPS
(Assignee)

Comment 2

5 years ago
Created attachment 754240 [details] [diff] [review]
patch B for discussion: make DrawQuad clean up after itself
Comment on attachment 754240 [details] [diff] [review]
patch B for discussion: make DrawQuad clean up after itself

Review of attachment 754240 [details] [diff] [review]:
-----------------------------------------------------------------

I definitely prefer this one. DrawQuad shouldn't have weird un-documented side effects.
Attachment #754240 - Flags: review+
(Assignee)

Updated

5 years ago
Attachment #754239 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/1e0fbd5000e3
Assignee: nobody → mstange
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.