876265 - One FM test fails on TBPL

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[Julien Wajsberg [:julienw]]

09:55:39     INFO -  gaia-unit-tests TEST-UNEXPECTED-FAIL | FM frequency dialer changed horizontal position of dialer | expected 0 to equal 0
09:55:39     INFO -  gaia-unit-tests INFO       | stack trace:
09:55:39     INFO -      Error: expected 0 to equal 0
09:55:39     INFO -          at chaiAssert (http://test-agent.gaiamobile.org:8080/common/test/helper.js:30)
09:55:39     INFO -          at notEqual (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:1276)
09:55:39     INFO -          at (anonymous) (http://fm.gaiamobile.org:8080/test/unit/fm_test.js:72)
09:55:39     INFO -          at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62)
09:55:39     INFO -          at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
09:55:39     INFO -          at runTest (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081)
09:55:39     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127)
09:55:39     INFO -          at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007)
09:55:39     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016)
09:55:39     INFO -          at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964)
09:55:39     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
09:55:39     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

Comment 1

[Mark Shiao]

Hi Julien, 

Not sure what TVPL is. :( Still somewhat a newbie to the environment.  Please let me know and I'll get on it.  

Thanks,
Mark

Comment 2

[Julien Wajsberg [:julienw]]

TBPL is the hopefully future infrastructure to run our unit tests.

I don't exactly know the difference between this and travis, sorry... My only thought here is that tbpl is maybe using a b2g18 build instead of a standard firefox 18 build like we do in Travis.

Jonathan, could you confirm please ?

Comment 3

[Jonathan Griffin (:jgriffin)]

Our efforts at getting these tests running in TBPL are targeted to gaia's master branch and b2g desktop builds on mozilla-central, per agreement with Vivien and Jonas.  So, they are run in a slightly different environment that Travis is using (Firefox 18).

B2G desktop builds from mozilla-central can be downloaded here:

http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central/

Comment 4

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

ping?

In today's b2g meeting, it was noted that these failing tests continue to block enabling tests on tbpl across all branches. Which makes us sad.

Who can own getting fixing up this test to pass, so we can unblock bug#833666?

Comment 5

[Pin Zhang [:pzhang] (inactive)]

(In reply to John O'Duinn [:joduinn] from comment #4)
> ping?
> 
> In today's b2g meeting, it was noted that these failing tests continue to
> block enabling tests on tbpl across all branches. Which makes us sad.
> 
> Who can own getting fixing up this test to pass, so we can unblock
> bug#833666?

I think we can just removed the |apps/fm/test/unit/api_test.js| which is supposed to run on the device to test WebFM API, however it's broken (bug 864246) now and we have bug 872417 to implement WebFM simulation.

mshiao, what do you think?

Comment 6

[Julien Wajsberg [:julienw]]

The bug here is about fm_test.js, not api_test.js.

Clearly, the the unit tests are _not_ supposed to run on the device, so if one of the test files you have is supposed to run on the device it should be moved to another location.

Comment 7

[Pin Zhang [:pzhang] (inactive)]

(In reply to Julien Wajsberg [:julienw] from comment #6)
> The bug here is about fm_test.js, not api_test.js.
> 
> Clearly, the the unit tests are _not_ supposed to run on the device, so if
> one of the test files you have is supposed to run on the device it should be
> moved to another location.

OK, I see, the api_test.js should be removed any way.

@mshiao, can you take this?

Comment 8

[Mark Shiao]

@Pin,

I'll remove the api_test.js. 

@Julien,

Not sure what's causing it to fail on TVPL. Local test are all passing.  Moving forward, I'm going to remove that specific test for the sake of passing on TVPL.  

Thanks,
Mark

Comment 9

[Mark Shiao]

Attachment: link to pull request

Hi Pin,

Can you review and approve?
Removed api_test.js as you requested and commented out the one test causing TBPL to fail.

Thanks,
Mark

Comment 10

[Pin Zhang [:pzhang] (inactive)]

Comment on attachment 764681 [details] [diff] [review]
link to pull request

I don't know why it broke the automation, but if it just work by commenting those lines of code, then please *remove* those lines and add the comment in the commit message, we can find those codes back in the commit log if we want them back at some day in the future.

Comment 11

[Julien Wajsberg [:julienw]]

Just to share with you: what we usually do in other apps is merely commenting _and_ adding a bug about reenabling it. The bug number would go in a comment next to the commented test.
Otherwise I'm afraid this will never be reenabled.

Comment 12

[Pin Zhang [:pzhang] (inactive)]

(In reply to Julien Wajsberg [:julienw] from comment #11)
> Just to share with you: what we usually do in other apps is merely
> commenting _and_ adding a bug about reenabling it. The bug number would go
> in a comment next to the commented test.
> Otherwise I'm afraid this will never be reenabled.

OK, thanks, @mark, then let's open another bug to reenable it if we *really* want to let them back.

Comment 13

[Mark Shiao]

landed on master commit#46bf3c83ad2870b865d3da3960f570ab59cc85eb
https://github.com/mozilla-b2g/gaia/commit/46bf3c83ad2870b865d3da3960f570ab59cc85eb