Closed Bug 876265 Opened 9 years ago Closed 8 years ago

One FM test fails on TBPL

Categories

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julienw, Assigned: mshiao)

References

Details

Attachments

(1 file)

09:55:39     INFO -  gaia-unit-tests TEST-UNEXPECTED-FAIL | FM frequency dialer changed horizontal position of dialer | expected 0 to equal 0
09:55:39     INFO -  gaia-unit-tests INFO       | stack trace:
09:55:39     INFO -      Error: expected 0 to equal 0
09:55:39     INFO -          at chaiAssert (http://test-agent.gaiamobile.org:8080/common/test/helper.js:30)
09:55:39     INFO -          at notEqual (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:1276)
09:55:39     INFO -          at (anonymous) (http://fm.gaiamobile.org:8080/test/unit/fm_test.js:72)
09:55:39     INFO -          at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62)
09:55:39     INFO -          at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
09:55:39     INFO -          at runTest (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081)
09:55:39     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127)
09:55:39     INFO -          at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007)
09:55:39     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016)
09:55:39     INFO -          at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964)
09:55:39     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
09:55:39     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)
Flags: needinfo?(mshiao)
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Hi Julien, 

Not sure what TVPL is. :( Still somewhat a newbie to the environment.  Please let me know and I'll get on it.  

Thanks,
Mark
Flags: needinfo?(mshiao)
TBPL is the hopefully future infrastructure to run our unit tests.

I don't exactly know the difference between this and travis, sorry... My only thought here is that tbpl is maybe using a b2g18 build instead of a standard firefox 18 build like we do in Travis.

Jonathan, could you confirm please ?
Flags: needinfo?(jgriffin)
Summary: One FM test fails on TVPL → One FM test fails on TBPL
Our efforts at getting these tests running in TBPL are targeted to gaia's master branch and b2g desktop builds on mozilla-central, per agreement with Vivien and Jonas.  So, they are run in a slightly different environment that Travis is using (Firefox 18).

B2G desktop builds from mozilla-central can be downloaded here:

http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central/
Flags: needinfo?(jgriffin)
ping?

In today's b2g meeting, it was noted that these failing tests continue to block enabling tests on tbpl across all branches. Which makes us sad.

Who can own getting fixing up this test to pass, so we can unblock bug#833666?
(In reply to John O'Duinn [:joduinn] from comment #4)
> ping?
> 
> In today's b2g meeting, it was noted that these failing tests continue to
> block enabling tests on tbpl across all branches. Which makes us sad.
> 
> Who can own getting fixing up this test to pass, so we can unblock
> bug#833666?

I think we can just removed the |apps/fm/test/unit/api_test.js| which is supposed to run on the device to test WebFM API, however it's broken (bug 864246) now and we have bug 872417 to implement WebFM simulation.

mshiao, what do you think?
The bug here is about fm_test.js, not api_test.js.

Clearly, the the unit tests are _not_ supposed to run on the device, so if one of the test files you have is supposed to run on the device it should be moved to another location.
(In reply to Julien Wajsberg [:julienw] from comment #6)
> The bug here is about fm_test.js, not api_test.js.
> 
> Clearly, the the unit tests are _not_ supposed to run on the device, so if
> one of the test files you have is supposed to run on the device it should be
> moved to another location.

OK, I see, the api_test.js should be removed any way.

@mshiao, can you take this?
@Pin,

I'll remove the api_test.js. 

@Julien,

Not sure what's causing it to fail on TVPL. Local test are all passing.  Moving forward, I'm going to remove that specific test for the sake of passing on TVPL.  

Thanks,
Mark
Hi Pin,

Can you review and approve?
Removed api_test.js as you requested and commented out the one test causing TBPL to fail.

Thanks,
Mark
Attachment #764681 - Flags: review?(pzhang)
Comment on attachment 764681 [details] [diff] [review]
link to pull request

I don't know why it broke the automation, but if it just work by commenting those lines of code, then please *remove* those lines and add the comment in the commit message, we can find those codes back in the commit log if we want them back at some day in the future.
Attachment #764681 - Attachment is patch: true
Attachment #764681 - Attachment mime type: text/html → text/plain
Attachment #764681 - Flags: review?(pzhang) → review+
Just to share with you: what we usually do in other apps is merely commenting _and_ adding a bug about reenabling it. The bug number would go in a comment next to the commented test.
Otherwise I'm afraid this will never be reenabled.
(In reply to Julien Wajsberg [:julienw] from comment #11)
> Just to share with you: what we usually do in other apps is merely
> commenting _and_ adding a bug about reenabling it. The bug number would go
> in a comment next to the commented test.
> Otherwise I'm afraid this will never be reenabled.

OK, thanks, @mark, then let's open another bug to reenable it if we *really* want to let them back.
landed on master commit#46bf3c83ad2870b865d3da3960f570ab59cc85eb
https://github.com/mozilla-b2g/gaia/commit/46bf3c83ad2870b865d3da3960f570ab59cc85eb
Assignee: nobody → mshiao
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.