Closed Bug 876347 Opened 6 years ago Closed 6 years ago

Move to->Recent-><name of your recent folder> is empty

Categories

(Thunderbird :: Folder and Message Lists, defect)

22 Branch
x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 24.0

People

(Reporter: Bogomil, Assigned: aceman)

References

Details

(Keywords: ux-consistency, ux-natural-mapping)

Attachments

(2 files)

1. Select a message or set of messages from your inbox and right click on it to expose the context menu.

2.Select Move to->Recent-><name of your recent folder>

Nothing is shown after recent. If there is no recent, maybe a message should be shown.
OS: Linux → All
Also if my "recent" is trash, it is still empty. It works only of "recent" is a real folder.
I do not understand this completely. Can you please attach a screenshot?
(In reply to :aceman from comment #2)
> I do not understand this completely. Can you please attach a screenshot?

Doing a screenshot of a contextual menu is hard.
OK, then how does it differ from this screenshot https://bug840591.bugzilla.mozilla.org/attachment.cgi?id=712973 ?
Is it that there are no recent folders to be shown, so the Recent submenu is empty? We could show a dummy item saying "<No items>" or disable the Recent submenu.
(In reply to :aceman from comment #5)
> Is it that there are no recent folders to be shown, so the Recent submenu is
> empty? We could show a dummy item saying "<No items>" or disable the Recent
> submenu.

This is it. Sorry for not being clear before. Recent submenu is completely empty, but still there is an arrow and the user expect to see something. A dummy item will be more than fine.
Disabling the Recent item would be easier. I imagine this only happens in a new profile where no folder is Recent yet?
Ok, so this is my version.

Bwinton, Neil:
If the small arrow (meaning Recent is a menu) should be hidden, that can be done. If you want to leave Recent enabled and make it contain one dummy disabled item saying "<no items>", say so :)
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #754980 - Flags: ui-review?(bwinton)
Attachment #754980 - Flags: feedback?(neil)
Comment on attachment 754980 [details] [diff] [review]
patch [checked in: comment 18]

Seems reasonable, although I don't know whether SeaMonkey uses recent folders anywhere yet.
Attachment #754980 - Flags: feedback?(neil) → feedback+
(In reply to :aceman from comment #7)
> Disabling the Recent item would be easier. I imagine this only happens in a
> new profile where no folder is Recent yet?

Or if the persistent information is lost. Not sure where. panacea.dat?
Otherwise, new profile should be the only case.


(In reply to neil@parkwaycc.co.uk from comment #9)
> I don't know whether SeaMonkey uses recent folders anywhere yet.

it does
(In reply to Wayne Mery (:wsmwk) from comment #10)
> (In reply to :aceman from comment #7)
> > Disabling the Recent item would be easier. I imagine this only happens in a
> > new profile where no folder is Recent yet?
> 
> Or if the persistent information is lost. Not sure where. panacea.dat?
> Otherwise, new profile should be the only case.

it's the mail.last_msg_movecopy_target_uri pref
Ah, scrap that, thats for "move again"
bug877620 is similar to that one.
Attachment #754980 - Flags: review?(mkmelin+mozilla)
Comment on attachment 754980 [details] [diff] [review]
patch [checked in: comment 18]

Review of attachment 754980 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #754980 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
Sorry, I was too fast :)
Comment on attachment 754980 [details] [diff] [review]
patch [checked in: comment 18]

Yeah, okay, ui-r=me.
Attachment #754980 - Flags: ui-review?(bwinton) → ui-review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/21f166b10149
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Attached patch fix testSplinter Review
This change broke a test so this fixes it again.
Attachment #754980 - Attachment is obsolete: true
Attachment #765535 - Flags: review?(mkmelin+mozilla)
Attachment #765535 - Flags: review?(mbanner)
Actually, the test does not fail on Thunderbird-Trunk on Linux (only other systems) but it did fail for me on Linux locally. Not sure why that is, it should fail on all systems. Aryx, could you please run a trybuild run with this patch (mozmill tests only) ?
Attachment #754980 - Attachment description: patch → patch [checked in: comment 18]
Attachment #754980 - Attachment is obsolete: false
Attachment #765535 - Flags: review?(mkmelin+mozilla)
Attachment #765535 - Flags: review?(mbanner)
Attachment #765535 - Flags: review+
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=ca903ae977f9

Great, so the patch fixed the test on OS X and Win but broke it now on Linux...
Let's try it on trunk if this isn't just the common linux popup fluke.
Keywords: checkin-needed
Depends on: 889752
You need to log in before you can comment on or make changes to this bug.