The default bug view has changed. See this FAQ.

Move to->Recent-><name of your recent folder> is empty

RESOLVED FIXED in Thunderbird 24.0

Status

Thunderbird
Folder and Message Lists
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Bogomil, Assigned: aceman)

Tracking

({ux-consistency, ux-natural-mapping})

22 Branch
Thunderbird 24.0
x86
All
ux-consistency, ux-natural-mapping
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
1. Select a message or set of messages from your inbox and right click on it to expose the context menu.

2.Select Move to->Recent-><name of your recent folder>

Nothing is shown after recent. If there is no recent, maybe a message should be shown.
Keywords: ux-consistency, ux-natural-mapping
OS: Linux → All
(Reporter)

Comment 1

4 years ago
Also if my "recent" is trash, it is still empty. It works only of "recent" is a real folder.
(Assignee)

Comment 2

4 years ago
I do not understand this completely. Can you please attach a screenshot?
(In reply to :aceman from comment #2)
> I do not understand this completely. Can you please attach a screenshot?

Doing a screenshot of a contextual menu is hard.
(Assignee)

Comment 4

4 years ago
OK, then how does it differ from this screenshot https://bug840591.bugzilla.mozilla.org/attachment.cgi?id=712973 ?
(Assignee)

Comment 5

4 years ago
Is it that there are no recent folders to be shown, so the Recent submenu is empty? We could show a dummy item saying "<No items>" or disable the Recent submenu.
(Reporter)

Comment 6

4 years ago
(In reply to :aceman from comment #5)
> Is it that there are no recent folders to be shown, so the Recent submenu is
> empty? We could show a dummy item saying "<No items>" or disable the Recent
> submenu.

This is it. Sorry for not being clear before. Recent submenu is completely empty, but still there is an arrow and the user expect to see something. A dummy item will be more than fine.
(Assignee)

Comment 7

4 years ago
Disabling the Recent item would be easier. I imagine this only happens in a new profile where no folder is Recent yet?
(Assignee)

Comment 8

4 years ago
Created attachment 754980 [details] [diff] [review]
patch [checked in: comment 18]

Ok, so this is my version.

Bwinton, Neil:
If the small arrow (meaning Recent is a menu) should be hidden, that can be done. If you want to leave Recent enabled and make it contain one dummy disabled item saying "<no items>", say so :)
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #754980 - Flags: ui-review?(bwinton)
Attachment #754980 - Flags: feedback?(neil)

Comment 9

4 years ago
Comment on attachment 754980 [details] [diff] [review]
patch [checked in: comment 18]

Seems reasonable, although I don't know whether SeaMonkey uses recent folders anywhere yet.
Attachment #754980 - Flags: feedback?(neil) → feedback+
(In reply to :aceman from comment #7)
> Disabling the Recent item would be easier. I imagine this only happens in a
> new profile where no folder is Recent yet?

Or if the persistent information is lost. Not sure where. panacea.dat?
Otherwise, new profile should be the only case.


(In reply to neil@parkwaycc.co.uk from comment #9)
> I don't know whether SeaMonkey uses recent folders anywhere yet.

it does

Comment 11

4 years ago
(In reply to Wayne Mery (:wsmwk) from comment #10)
> (In reply to :aceman from comment #7)
> > Disabling the Recent item would be easier. I imagine this only happens in a
> > new profile where no folder is Recent yet?
> 
> Or if the persistent information is lost. Not sure where. panacea.dat?
> Otherwise, new profile should be the only case.

it's the mail.last_msg_movecopy_target_uri pref

Comment 12

4 years ago
Ah, scrap that, thats for "move again"
(Reporter)

Comment 13

4 years ago
bug877620 is similar to that one.
(Assignee)

Updated

4 years ago
Attachment #754980 - Flags: review?(mkmelin+mozilla)

Comment 14

4 years ago
Comment on attachment 754980 [details] [diff] [review]
patch [checked in: comment 18]

Review of attachment 754980 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #754980 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
ui-r?
Keywords: checkin-needed
(Assignee)

Comment 16

4 years ago
Sorry, I was too fast :)
Comment on attachment 754980 [details] [diff] [review]
patch [checked in: comment 18]

Yeah, okay, ui-r=me.
Attachment #754980 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/21f166b10149
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
(Assignee)

Comment 19

4 years ago
Created attachment 765535 [details] [diff] [review]
fix test

This change broke a test so this fixes it again.
Attachment #754980 - Attachment is obsolete: true
Attachment #765535 - Flags: review?(mkmelin+mozilla)
Attachment #765535 - Flags: review?(mbanner)
(Assignee)

Comment 20

4 years ago
Actually, the test does not fail on Thunderbird-Trunk on Linux (only other systems) but it did fail for me on Linux locally. Not sure why that is, it should fail on all systems. Aryx, could you please run a trybuild run with this patch (mozmill tests only) ?
(Assignee)

Updated

4 years ago
Attachment #754980 - Attachment description: patch → patch [checked in: comment 18]
Attachment #754980 - Attachment is obsolete: false
Attachment #765535 - Flags: review?(mkmelin+mozilla)
Attachment #765535 - Flags: review?(mbanner)
Attachment #765535 - Flags: review+
(Assignee)

Comment 21

4 years ago
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=ca903ae977f9

Great, so the patch fixed the test on OS X and Win but broke it now on Linux...
(Assignee)

Comment 22

4 years ago
Let's try it on trunk if this isn't just the common linux popup fluke.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/645be9e5edaf
Flags: in-testsuite+
Keywords: checkin-needed
Depends on: 889752
You need to log in before you can comment on or make changes to this bug.