876348 - java.lang.NullPointerException: at org.mozilla.gecko.gfx.GLController.getEGLError(GLController.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It's #201 crasher in 21.0 and #147 in 22.0b2.
It first showed up in 21.0b1.

Here is a crash report: bp-2b94b10c-861c-46d3-89c7-b8ddf2130526.

java.lang.NullPointerException
	at org.mozilla.gecko.gfx.GLController.getEGLError(GLController.java:238)
	at org.mozilla.gecko.gfx.GLController.access$800(GLController.java:31)
	at org.mozilla.gecko.gfx.GLController$1.run(GLController.java:153)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:123)
	at android.app.ActivityThread.main(ActivityThread.java:4627)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:521)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:868)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:626)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.gfx.GLController.getEGLError%28GLController.java%29

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 758590 [details] [diff] [review]
Patch

Review of attachment 758590 [details] [diff] [review]:
-----------------------------------------------------------------

Somehow this is being called before initEGL() I guess? Probably from surfaceChanged() callback? I would rather just not call getEGLError() when we don't have an EGL context, but I guess I'll r+

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I'd still like to have some logging there for those cases where we think there's a GL error, even if it's before initEGL(). Also the fact that this crash only happens on Froyo and Gingerbread is a little suspicious. Maybe preventing the crash will expose some other bug and it would be good to know that it went through this code path.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3519bf161631

Comment 4

[Scoobidiver (away)]

I see one crash on ICS: bp-34134a5b-415e-4228-b442-ba6712130603.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Well then.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3519bf161631