876388 - "Successfully signed in" message displayed after submitting an app

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Iulian Timis]

Steps to reproduce:
1. Load Submit An App page https://marketplace-dev.allizom.org/developers/submit/
2. Complete all the fields and submit an app
3. Finish the app submission and get to step 4 (Finished! page)

Expected results:
There are no design or layout issues.

Actual results:
"Successfully signed in. Click here to reload." message is displayed under the footer.

Notes/Issues:
Verified on FF24 (Win 7).
Screencast for this issue http://screencast.com/t/NYchvA7K

Comment 1

[Wil Clouser [:clouserw]]

*cvan talks about how basta knows how to fix this bug*
Wil: So basically you're throwing basta under the bus?
Cvan: I'm not throwing him under the bus.  I'm saying he's very competent in this area

Comment 3

[Victor Carciu]

This is still reproducible, but only on stage.

Comment 4

[Matt Basta [:basta]]

No, it's still reproducible everywhere; it just has a much more complicated set of steps to reproduce. It's not an edge case, but it'll happen on subsequent (i.e.: not the first) logins after a certain period of time has passed.

The fix here is to ignore navigator.id.watch when we know the user is logged in already and pay attention to it when they're not.

Comment 5

[Matt Basta [:basta]]

This should fix it:

https://github.com/mozilla/zamboni/commit/e7eb8854183a4ff675de598febc51c79063e2952

Reopen if the problem is still reproducible.

Comment 6

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/developers/ on FF24 (Win 7).
Postfix screencast http://screencast.com/t/hwLSaiOg6osd
Closing bug.