Closed
Bug 876407
Opened 13 years ago
Closed 13 years ago
Search MakeAPI by username
Categories
(Webmaker Graveyard :: MakeAPI, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cade, Assigned: cade)
Details
Attachments
(1 file)
This will basically allow for searching by maker username. Behind the scenes, the MakeAPI will have to query the login server for the email address of the user (using the username) and filter on makes by that email.
This will likely have a fix in the login server and in the MakeAPI
|
Assignee | |
Comment 1•13 years ago
|
||
This will also have the MakeAPI tack on the username for each search result.
|
|
Assignee | |
Updated•13 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•13 years ago
|
||
So, the code that appends the maker's subdomain is a little difficult to read, but it does work.
Attachment #754561 -
Flags: review?(david.humphrey)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 754561 [details] [review]
https://github.com/mozilla/MakeAPI/pull/61
This looks a lot cleaner.
Attachment #754561 -
Flags: review?(david.humphrey) → review+
|
||
Comment 4•13 years ago
|
||
Commit pushed to master at https://github.com/mozilla/MakeAPI
https://github.com/mozilla/MakeAPI/commit/2a87e489bbd028e8520ba1b86ddb89001cb49d6c
Fix Bug 876407 - Search by username/subdomain, get maker username/subdomain in search results
|
|
||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•