Open
Bug 876428
Opened 11 years ago
Updated 2 months ago
Test for bug 874252
Categories
(Core :: Storage: IndexedDB, defect, P5)
Core
Storage: IndexedDB
Tracking
()
NEW
People
(Reporter: baku, Unassigned)
Details
Attachments
(1 file, 4 obsolete files)
|
3.27 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #754458 -
Flags: review?(khuey)
|
Reporter | |
Comment 1•11 years ago
|
||
Any idea why I cannot catch the exception here? https://tbpl.mozilla.org/?tree=Try&rev=8747406aefe8
Comment on attachment 754458 [details] [diff] [review] patch Review of attachment 754458 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/indexedDB/test/test_bug874252.html @@ +12,5 @@ > +<body> > +<script> > + > +indexedDBPref = SpecialPowers.getBoolPref("dom.indexedDB.enabled"); > +SpecialPowers.setBoolPref("dom.indexedDB.enabled", false); This should use pushPrefEnv instead. @@ +23,5 @@ > + > + SpecialPowers.setBoolPref("dom.indexedDB.enabled", indexedDBPref); > + SimpleTest.finish(); > + > + e.stopPropagation(); You want to call preventDefault to stop this from hitting window.onerror.
Attachment #754458 -
Flags: review?(khuey) → review-
|
|
Reporter | |
Comment 3•11 years ago
|
||
preventDefault is not enough for IPC tests. Any other suggestion?
Attachment #754458 -
Attachment is obsolete: true
Attachment #754695 -
Flags: review?(khuey)
Debug it? Something is definitely broken then!
http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/ipc/IndexedDBParent.cpp#365 is the code that is supposed to handle this.
But that code may not handle requests from deleteDatabase ...
Component: DOM → DOM: IndexedDB
Comment on attachment 754695 [details] [diff] [review] patch I can't r+ a test that turns the tree orange ...
Attachment #754695 -
Flags: review?(khuey)
|
|
Reporter | |
Comment 8•11 years ago
|
||
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #6) > But that code may not handle requests from deleteDatabase ... This is exactly the feedback I needed. Thanks! I'm testing a new version of this patch on try.
|
|
Reporter | |
Comment 9•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=5ca54fc60e7f
Attachment #754695 -
Attachment is obsolete: true
Attachment #761430 -
Flags: review?(khuey)
Comment on attachment 761430 [details] [diff] [review] patch Review of attachment 761430 [details] [diff] [review]: ----------------------------------------------------------------- b2g might want this ...
Attachment #761430 -
Flags: review?(khuey) → review+
|
|
Reporter | |
Updated•11 years ago
|
Keywords: checkin-needed
You need a better commit message before you check this in.
Keywords: checkin-needed
|
|
Reporter | |
Comment 12•11 years ago
|
||
Done :) About b2g, I don't think the patch for the leaks landed on b2g18... but maybe it should. I'll check this tomorrow.
Attachment #761430 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•9 years ago
|
Assignee: amarchesini → nobody
|
||
Updated•6 years ago
|
Priority: -- → P5
|
||
Updated•2 years ago
|
Severity: normal → S3
| Comment hidden (spam) |
|
|
||
Updated•2 months ago
|
Attachment #9382791 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•