876446 - Use MakeAPI to fill out remaining static parts of new Make Details page

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Matthew Schranz [:mjschranz]]

This list includes but is not limited to:

- Remixed from project thumbnail
- Project locale(s)
- Logic to remove remixed from details if project isn't a remix
- Date information about when the project was created. Consider using npm https://github.com/mozilla/webmaker.org/blob/master/public/ext/js/moment.js
- General removal of other static data

Comment 1

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/28

Tweeks are going to have to be made, especially based on UI overview from Kate but is has all of the above points done as best as I can tell.

Comment 2

[David Humphrey (:humph)]

Comment on attachment 756686 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/28

I'll let Kate weigh in on the UI changes.  I'm unclear why you're delaying this and doing it all client side when you're already rendering the template server side.  Why not just put that data in as you publish and skip the client-side stuff?

Travis tests are failing, which I'm sure you saw.

Comment 3

[Matthew Schranz [:mjschranz]]

Travis test fails are not related and are filed in a bug I can't find but is assigned to Chris.

I did this client side because certain pieces of data are dynamic. As a project get's remixed more and more the number wouldn't go up unless someone republished again for example.

Comment 4

[Matthew Schranz [:mjschranz]]

I've made a bunch of UI updates/changes around this.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 756686 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/28

I'm not able to get remixed from to work, and when I try, I get placeholder data. Could be my local system/makeapi database. Still not able to clear it.

I say land this, though and iterate.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/25dff2782c51c6544542a5228c2f1e1190e1bf0f
Fix Bug 876446 - Add makeapi details to remaining parts of details page