876454 - BaselineCompiler: Compile JSOP_LEAVEBLOCKEXPR and JSOP_LEAVEFORLETIN

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

We can now compile things like

  for (let x in y) { }

and

  print(let (x = a) x * 3);

Comment 1

[Tom S [:evilpie]]

Comment on attachment 754488 [details] [diff] [review]
Patch

Review of attachment 754488 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/BaselineCompiler.cpp
@@ +2208,5 @@
> +        return false;
> +
> +    // Pop slots pushed by JSOP_ENTERBLOCK, but leave the topmost value
> +    // on the stack.
> +    frame.popRegsAndSync(1);

This threw me of, but the interpreter also does something weird, so carry on :)

Comment 2

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc0a521fad43

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fc0a521fad43