Closed
Bug 876457
Opened 12 years ago
Closed 12 years ago
Implement S3 redirects for /edit and /remix routes in popcorn maker
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: thecount, Assigned: thecount)
References
Details
(Whiteboard: s=2013w24 p=1)
Attachments
(1 file)
For whatever the project's url is, a /edit should take you to the edit.
Right now we're storing the remixUrl in the makeapi.
I should be able to do makeResult.url + "/edit" or something similar. Thimble is going to be the same so it'll be tool agnostic.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → schranz.m
Assignee | ||
Updated•12 years ago
|
Summary: standardize popcorn's /edit url → Implement S3 redirects for /edit and /remix routes in popcorn maker
Assignee | ||
Comment 1•12 years ago
|
||
I think I need to be more clear on my intent in this ticket.
This is, to create something at the user domain level. That is, inside S3, that allows other tools to generate an edit url from the domain level S3 URL.
Also, something like this for thimble is bug 876440
Apparently that had to be done in two tickets too. So split this one as needed.
Assignee | ||
Comment 2•12 years ago
|
||
It has some blockers before you can see the redirect being useful, but it does in fact redirect to where it is going to be, once the blockers land.
Attachment #758201 -
Flags: review?(jon)
Comment 3•12 years ago
|
||
Not to point out the obvious, but this doesn't provide a local solution at all.
Infact, the app crashes completely when using local storage.
Assignee | ||
Comment 4•12 years ago
|
||
yeah, I should make sure it works the old way if not using s3.
Comment 5•12 years ago
|
||
Comment on attachment 758201 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/34
r-, comments in the PR
Attachment #758201 -
Flags: review?(jon) → review-
Updated•12 years ago
|
Whiteboard: s=2013w24
Updated•12 years ago
|
Whiteboard: s=2013w24 → s=2013w24 p=1
Updated•12 years ago
|
Severity: normal → blocker
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 758201 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/34
Updates.
Pretty much just re did it.
Attachment #758201 -
Flags: review- → review?(jon)
Assignee | ||
Updated•12 years ago
|
Attachment #758201 -
Flags: review?(jon) → review?(david.humphrey)
Comment 7•12 years ago
|
||
Comment on attachment 758201 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/34
Put this back on me for review after Jon's server.js rewrite lands, and you've rebased.
Attachment #758201 -
Flags: review?(david.humphrey)
Assignee | ||
Updated•12 years ago
|
Attachment #758201 -
Flags: review?(jon)
Updated•12 years ago
|
Attachment #758201 -
Flags: review?(jon) → review+
Assignee | ||
Comment 8•12 years ago
|
||
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/366d61b434a47ad52f4ffe592ab94d97cb006a91
It does not work until jbuck plugs in the rest of his changes.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•