Implement S3 redirects for /edit and /remix routes in popcorn maker

RESOLVED FIXED

Status

--
blocker
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: thecount, Assigned: thecount)

Tracking

Details

(Whiteboard: s=2013w24 p=1)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
For whatever the project's url is, a /edit should take you to the edit.

Right now we're storing the remixUrl in the makeapi.

I should be able to do makeResult.url + "/edit" or something similar. Thimble is going to be the same so it'll be tool agnostic.
(Assignee)

Updated

5 years ago
Blocks: 876451
(Assignee)

Updated

5 years ago
Blocks: 876459
(Assignee)

Updated

5 years ago
Assignee: nobody → schranz.m
(Assignee)

Updated

5 years ago
Summary: standardize popcorn's /edit url → Implement S3 redirects for /edit and /remix routes in popcorn maker
(Assignee)

Comment 1

5 years ago
I think I need to be more clear on my intent in this ticket.

This is, to create something at the user domain level. That is, inside S3, that allows other tools to generate an edit url from the domain level S3 URL.

Also, something like this for thimble is bug 876440

Apparently that had to be done in two tickets too. So split this one as needed.
Assignee: schranz.m → scott
Depends on: 876522
(Assignee)

Comment 2

5 years ago
Created attachment 758201 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/34

It has some blockers before you can see the redirect being useful, but it does in fact redirect to where it is going to be, once the blockers land.
Attachment #758201 - Flags: review?(jon)
Not to point out the obvious, but this doesn't provide a local solution at all.

Infact, the app crashes completely when using local storage.
(Assignee)

Comment 4

5 years ago
yeah, I should make sure it works the old way if not using s3.

Comment 5

5 years ago
Comment on attachment 758201 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/34

r-, comments in the PR
Attachment #758201 - Flags: review?(jon) → review-

Updated

5 years ago
Whiteboard: s=2013w24

Updated

5 years ago
Whiteboard: s=2013w24 → s=2013w24 p=1
Severity: normal → blocker
Blocks: 880853
(Assignee)

Comment 6

5 years ago
Comment on attachment 758201 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/34

Updates.

Pretty much just re did it.
Attachment #758201 - Flags: review- → review?(jon)
(Assignee)

Updated

5 years ago
Attachment #758201 - Flags: review?(jon) → review?(david.humphrey)
Comment on attachment 758201 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/34

Put this back on me for review after Jon's server.js rewrite lands, and you've rebased.
Attachment #758201 - Flags: review?(david.humphrey)
(Assignee)

Updated

5 years ago
Depends on: 863366
(Assignee)

Updated

5 years ago
Attachment #758201 - Flags: review?(jon)

Updated

5 years ago
Attachment #758201 - Flags: review?(jon) → review+
(Assignee)

Comment 8

5 years ago
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/366d61b434a47ad52f4ffe592ab94d97cb006a91

It does not work until jbuck plugs in the rest of his changes.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.