876483 - [Messages][groupmms] we always display the first recipient's information, even if it's not a contact and other are

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* start a new message
* add 2 recipients, the first one without a contact (a "pure" number), the second one with a contact
* switch to mms by attaching an image
* send the MMS (note: you can enable flight mode if you don't want to send the message)

Expected:
* the header switches to "<name of the contact> (+1)"

Actual:
* the header switches to "<first number> (+1)"

Note that in Bug 858362 we changed how getContactDetails work when we feed it multiple contacts, so that's probably what we need to do here too.

Blocking the release because it's the polishing of the MMS work.

Comment 1

[Julien Wajsberg [:julienw]]

NI dietrich for leo+

Comment 2

[Julien Wajsberg [:julienw]]

Steve, how is it going ? Are you able to work on this, or could someone else take it ?

Comment 3

[Rick Waldron [:rwaldron]]

I can take this if Steve is ok with that

Comment 4

[Julien Wajsberg [:julienw]]

I'm happy with anyone doing it, just don't assign yourself if you don't work on it, so that somebody else can take it :)

Comment 5

[Steve Chung [:steveck]]

Sorry the late reply. I got stuck in other bugs but I think it's not a complicate polishing work, I'll send the patch today, thanks.

Comment 6

[Steve Chung [:steveck]]

Attachment: Patch for showing the validate contact information

Hi Julien, I haven't finished the test cases yet, but you could take a look first that the solution is feasible or not. Thanks.

Comment 7

[Rick Waldron [:rwaldron]]

Steve, I'm blocking on this one because I realized that this will be trivial once bug 875836 lands

reference: https://github.com/mozilla-b2g/gaia/pull/10394#issuecomment-19464468

Comment 8

[Julien Wajsberg [:julienw]]

Then I'm waiting.

Comment 9

[Steve Chung [:steveck]]

Ok for me, I will update the patch after bug 875836, thanks.

Comment 10

[Alex Keybl [:akeybl]]

Triage agreed this isn't a blocker, since this is really just polish. UX can renominate for leo+ if they strongly disagree.

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 762603 [details]
Patch for showing the validate contact information

cleaning my review flag until the new patch is ready

Comment 12

[Julien Wajsberg [:julienw]]

Will probably disable multi-recipient threads in 1.1 anyway.

Comment 13

[ayman maat :maat]

(In reply to Alex Keybl [:akeybl] from comment #10)
> Triage agreed this isn't a blocker, since this is really just polish. UX can
> renominate for leo+ if they strongly disagree.

I dont believe this is a blocker, especially with reference to Comment 12. Therefore I will not be renominating to LEO

Comment 14

[Dietrich Ayala (:dietrich)]

Per triage decision, all groupmms moving to koi? as the feature is no longer in leo.

Comment 15

[Rick Waldron [:rwaldron]]

Steve, can I take this?

Comment 16

[Steve Chung [:steveck]]

Oh, sure, I haven't rework the patch yet. Feel free to take it.

Comment 17

[Julien Wajsberg [:julienw]]

This should be easier once we have contact information inside a local DB.

Comment 18

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 19

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(