876508 - Remove l10n for Sunbird

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Joshua Cranmer [:jcranmer]]

+++ This bug was initially created as a clone of Bug #866903 +++

(In reply to Joshua Cranmer [:jcranmer] from comment #7)
> I think calendar/locales/en-US/{chrome/sunbird, installer, updater} can be
> removed, but l10n is so far removed from my area of expertise that I'm not
> going to try unless I'm told to.

I also think these can go. Please file a followup bug if you don't take care here. It might not be that bad to do this in the next cycle so that the string "changes" are not required for the upcoming ESR.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Remove l10n files - v1

This patch takes care of removing the l10n files. I hope I got every bit of it. I've also filed bug 978591 to get MOZ_CHROME_FILE_FORMAT out of the Makefile, then we can remove it altogether.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Remove unused dtd entries - v1

This patch removes some unused .dtd entries. Not all of them will be related to Sunbird, but its hard to differ.

I found them using a combination of grep calls. I didn't bother to search through our .properties file entries, because its really a pain and is at least a half day of risky manual work.

Comment 3

[Martin Schröder [:mschroeder]]

Comment on attachment 8384306 [details] [diff] [review]
Remove unused dtd entries  - v1

r=mschroeder

Comment 4

[Martin Schröder [:mschroeder]]

Comment on attachment 8384305 [details] [diff] [review]
Remove l10n files - v1

r=mschroeder, although I can not tell if the l10n Makefiles are okay after the cleanup. Please have another look at the Makefile target around https://mxr.mozilla.org/comm-central/source/calendar/lightning/lightning-packager.mk#157, because you remove the defines.inc in this patch, which seems to be referenced there.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Thanks for the hint. I've made some slight modifications to not process defines.inc.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 0c6c07afee38

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 3740baf30c02

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Bustage fix pushed in comm-central changeset 27516289f088.