Controls sometimes fail to fadeout

RESOLVED FIXED in mozilla24

Status

()

Toolkit
Video/Audio Controls
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Dolske, Assigned: Dolske)

Tracking

unspecified
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Noticed this looking at bug 876380. The testcase there has a video that is not very tall, and is just enough to trigger the "immediate" case in hideClickToPlay(). When that happens there is no transition, and thus onTransitionEnd() is never called.

And so while the CTP section does get set to opacity:0, it's never hidden with |element.hidden=true|.

And so in onMouseInOut the follow code gets hit:

    // Keep the controls visible if the click-to-play is visible.
     if (!this.clickToPlay.hidden)
         return;

And thus the control bar is never hidden when the mouse exits the video.

Adding |this.clickToPlay.hidden = true;| to the "immediate" case in hideClickToPlay() makes things work.
(Assignee)

Updated

5 years ago
Blocks: 666306
(Assignee)

Comment 1

5 years ago
Created attachment 754648 [details] [diff] [review]
Patch v.1

Fix seems harmless enough.
Assignee: nobody → dolske
Attachment #754648 - Flags: review?(jaws)
Attachment #754648 - Flags: review?(jaws) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2078f638f08a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.