Closed Bug 876550 Opened 8 years ago Closed 8 years ago
Controls sometimes fail to fadeout
Noticed this looking at bug 876380. The testcase there has a video that is not very tall, and is just enough to trigger the "immediate" case in hideClickToPlay(). When that happens there is no transition, and thus onTransitionEnd() is never called. And so while the CTP section does get set to opacity:0, it's never hidden with |element.hidden=true|. And so in onMouseInOut the follow code gets hit: // Keep the controls visible if the click-to-play is visible. if (!this.clickToPlay.hidden) return; And thus the control bar is never hidden when the mouse exits the video. Adding |this.clickToPlay.hidden = true;| to the "immediate" case in hideClickToPlay() makes things work.
Fix seems harmless enough.
Assignee: nobody → dolske
Attachment #754648 - Flags: review?(jaws)
Status: NEW → ASSIGNED
Attachment #754648 - Flags: review?(jaws) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.