876550 - Controls sometimes fail to fadeout

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Justin Dolske [:Dolske]]

Noticed this looking at bug 876380. The testcase there has a video that is not very tall, and is just enough to trigger the "immediate" case in hideClickToPlay(). When that happens there is no transition, and thus onTransitionEnd() is never called.

And so while the CTP section does get set to opacity:0, it's never hidden with |element.hidden=true|.

And so in onMouseInOut the follow code gets hit:

    // Keep the controls visible if the click-to-play is visible.
     if (!this.clickToPlay.hidden)
         return;

And thus the control bar is never hidden when the mouse exits the video.

Adding |this.clickToPlay.hidden = true;| to the "immediate" case in hideClickToPlay() makes things work.

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Fix seems harmless enough.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

http://i.qkme.me/3uhtc5.jpg

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2078f638f08a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2078f638f08a