876598 - [Latin] Dead space on the sides of row 2, plus dead space at bottom of keyboard

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

In latin keyboard the space left and right of row 2 are dead, Windows Phone f.e. handles this by making that space bound to the A and L.

Also there is dead space between the bottom of the keyboard and the keys right above, which makes me mistype every now and then.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch

This PR removes the padding-bottom of the keyboard area and makes the last keyboard row higher instead. It also enlarges the key container for the first and last key in a row when the full width is not being used, to fill up the row completely. This reduces mistapping in the keyboard as there is no more dead space.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 754756 [details] [diff] [review]
Patch

This is a great improvement!

r+ if you:

-- address the one comment on Github
-- the visual looks exactly the same, or UX f+ the screenshot of the visual changes
-- the keyboard doesn't break on non HVGA phones (you should at least try WVGA and qHD (width 480px and 540px respectively)

Thank you!

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Diff between master and this patch (in Pixlr format)

Attached a Pixlr file with two layers that shows that the keyboard layout hasnt changed.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Checked on various resolutions, including on GP Peak; changed code according to the GH comment.

Landed in https://github.com/mozilla-b2g/gaia/commit/70162ee3e95bc84034df0b13a7ec69ea1bbd3cb9

Comment 5

[David Flanagan [:djf]]

This patch appears to have caused bug 882954.

I suspect that this patch also causes the wrong size A and L keys when the keyboard is in landscape mode.