All users were logged out of Bugzilla on October 13th, 2018

[Latin] Dead space on the sides of row 2, plus dead space at bottom of keyboard

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: janjongboom, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

In latin keyboard the space left and right of row 2 are dead, Windows Phone f.e. handles this by making that space bound to the A and L.

Also there is dead space between the bottom of the keyboard and the keys right above, which makes me mistype every now and then.
Created attachment 754756 [details] [diff] [review]
Patch

This PR removes the padding-bottom of the keyboard area and makes the last keyboard row higher instead. It also enlarges the key container for the first and last key in a row when the full width is not being used, to fill up the row completely. This reduces mistapping in the keyboard as there is no more dead space.
Attachment #754756 - Flags: review?(timdream)
Attachment #754756 - Flags: feedback?(jcarpenter)
Comment on attachment 754756 [details] [diff] [review]
Patch

This is a great improvement!

r+ if you:

-- address the one comment on Github
-- the visual looks exactly the same, or UX f+ the screenshot of the visual changes
-- the keyboard doesn't break on non HVGA phones (you should at least try WVGA and qHD (width 480px and 540px respectively)

Thank you!
Attachment #754756 - Flags: review?(timdream)
Attachment #754756 - Flags: review+
Attachment #754756 - Flags: feedback?(jcarpenter)
Created attachment 755272 [details]
Diff between master and this patch (in Pixlr format)

Attached a Pixlr file with two layers that shows that the keyboard layout hasnt changed.
Checked on various resolutions, including on GP Peak; changed code according to the GH comment.

Landed in https://github.com/mozilla-b2g/gaia/commit/70162ee3e95bc84034df0b13a7ec69ea1bbd3cb9
(Reporter)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
This patch appears to have caused bug 882954.

I suspect that this patch also causes the wrong size A and L keys when the keyboard is in landscape mode.
Depends on: 882954

Updated

5 years ago
Depends on: 884703
You need to log in before you can comment on or make changes to this bug.