876673 - Article for close button brokes page layout on revision page.

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P4)

Description

[Michał Frontczak [:fxa90id] ♥]

Attachment: breaking X

After changes from https://bugzilla.mozilla.org/show_bug.cgi?id=842527, close button appeare in changes page.

Solution:
 - X should disapear from changes page.
 - X should only appear when editing article in floating box.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Why was this marked as invalid?

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

:fxa90id, can you provide a screenshot and link to the issue?

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

See: https://support.mozilla.org/en-US/forums/contributors/709257

Comment 4

[Michał Frontczak [:fxa90id] ♥]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #2)
> :fxa90id, can you provide a screenshot and link to the issue?

https://bugzilla.mozilla.org/attachment.cgi?id=754800 its already here :)

Comment 5

[Kadir Topal [:atopal]]

The whole widget looks broken. This is a paper cut issue. Let's try to slide this in with the next sprint.

Comment 6

[Michał Frontczak [:fxa90id] ♥]

Sorry I was pretty busy moving to US. I will fix it this weekend.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Sicne it is a paper cut, I'd like to keep it as a mentored bug in the backlog.

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Q3 is over... => Q4

Comment 9

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Michael, did you still want to work on it?

Comment 10

[Michał Frontczak [:fxa90id] ♥]

Yes, I will fix this weekend :)

Comment 11

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

(In reply to Michał Frontczak[:fxa90id] from comment #10)
> Yes, I will fix this weekend :)

Assigning!

Comment 12

[Michał Frontczak [:fxa90id] ♥]

https://github.com/mozilla/kitsune/pull/1667

Comment 13

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/5a510f89b40172e892c0a82b53a4d8f700e1af48


Thanks Michał!

Comment 14

[Ricky Rosario [:rrosario, :r1cky]]

current sprint.

Comment 15

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now.