876703 - Browser invocation from SMS is not working with URLs of type: http://

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

Description

[Maria Angeles Oteo (:oteo)]

Sending or receiving an SMS with an URL of this type (using http://) http://www.mozilla.org or http://mozilla.org is not working

When you send or receive a SMS with this kind of URL, it seems that the system recognizes it as a valid URL, as it is underlined, but when you tap on it, the browser is not launched so you can not access to the link.

Otherwise if you send or receive an SMS with an URL of this type: www.mozilla.org is working without problem.

tested with v1-train
Gecko:c930902
Gaia:a6d5dc7
Device:unagi

Comment 1

[Maria Angeles Oteo (:oteo)]

Requesting leo+, as this seems to be a regression. LG requested the implementation of this US (bug 838005) and need to be fixed.

In e-mail the access to this type of URL is working fine

Comment 2

[Maria Angeles Oteo (:oteo)]

I forgot to mention that for reproducing this fault you should send an SMS with just one URL, I am suffering strange behaviours and sometimes if I mixed several clickable contents it's not always happening...

Comment 3

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: screenshot

If the first character is uppercase in the url, it will not work.
As the attachment, "http://mozilla.org" can be tapped, but "Http://mozilla.org" can not be tapped.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

It's just because the filter set for activity doesn't apply on URLs with upper-cased protocol. This should happen for any apps trying to open URL with browser I think..

Comment 5

[Maria Angeles Oteo (:oteo)]

(In reply to GaryChen [:GaryChen] (MoCo-TW) from comment #3)
> Created attachment 756462 [details]
> screenshot
> 
> If the first character is uppercase in the url, it will not work.
> As the attachment, "http://mozilla.org" can be tapped, but
> "Http://mozilla.org" can not be tapped.

you are right, but it only happens with URL starting with Http:// 
If for example I am sending Www.mozilla.org (the first character is uppercase) I can open the URL when I tap on it.


Besides (perhaps I should open a new bug for it) after sending an SMS with an URL that does not work, when I compose other SMS and try to send it the "send" button does not work. Only I am able to send another SMS, deleting the last sent SMS with the failed URL...

Comment 6

[Ben Francis [:benfrancis]]

Comment on attachment 757294 [details]
patch

Thanks for the patch. r+me.

Comment 7

[Ben Francis [:benfrancis]]

Merged into master in https://github.com/mozilla-b2g/gaia/commit/9d36cc1213e9dadd74b29babb55518bfd919963f

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thanks for reviewing Ben!

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 9d36cc1213e9dadd74b29babb55518bfd919963f to:
v1-train: e780e9345e818c92652c028ca7a2fc7d4775b219

Comment 10

[Parul Mathur]

Executed test case in MozTrap https://moztrap.mozilla.org/manage/case/8745/ and verified fixed on:
Device: Leo phone
Build Identifier: 20130621070212
Update channel: leo/1.1/nightly
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a34f6d62cb05
Gaia: cca61224e6df8e9f7e450d77cb6a8cf91029be641371823447
Git commit info: 2013-06-21 14:04:07
OS version: 1.1.0.0-prerelease