876732 - Add a --debugger-args argument when running mochitest using mach.

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Paul Adenot (:padenot)]

Attachment: patch

And fail if --debugger-args is passed, bug --debugger is not.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Please use 4-space indentation.

Comment 2

[(no longer active)]

gps is on vacation, FWIW.

Comment 3

[Paul Adenot (:padenot)]

Attachment: patch

Now with proper white spaces.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 755248 [details] [diff] [review]
patch

Review of attachment 755248 [details] [diff] [review]:
-----------------------------------------------------------------

Kind of sucks that we have to keep commandline arguments in sync between the Mochitest harness and the runner, it'd be nice to figure out a way to share that between them.

::: testing/mochitest/mach_commands.py
@@ +214,5 @@
>      debugger = CommandArgument('--debugger', '-d', metavar='DEBUGGER',
>          help='Debugger binary to run test in. Program name or path.')
>      func = debugger(func)
>  
> +    debugger_args = CommandArgument('--debugger-args', '-da',

I'd drop the short -da form, doesn't seem super useful.

Comment 5

[Paul Adenot (:padenot)]

Pushed with the short switch removed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c234d35fb5c

Comment 7

[Jeff Hammel]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> Comment on attachment 755248 [details] [diff] [review]
> patch
> 
> Review of attachment 755248 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Kind of sucks that we have to keep commandline arguments in sync between the
> Mochitest harness and the runner, it'd be nice to figure out a way to share
> that between them.

Maybe too much future thinking but I filed bug 877731 to this end

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c234d35fb5c