876764 - Entering customization mode with open customization tab breaks it

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Morpheus3k]

STR:
1. Open some tabs
2. Open Customization mode via Menu Panel
3. Switch to another tab
4. Open Customization mode via Menu Panel (again)

Expected:
Switch to customization tab.

Actual:
Switch to customization tab, but breaks the mode.

Comment 1

[:Gijs (he/him)]

Can't reproduce this on current OS X builds. Can you try this build? I suspect Jared's fix for undo close tab fixed this: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-macosx64/1369751904/firefox-24.0a1.en-US.mac.dmg

Comment 2

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #1)
> Can't reproduce this on current OS X builds. Can you try this build? I
> suspect Jared's fix for undo close tab fixed this:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-macosx64/
> 1369751904/firefox-24.0a1.en-US.mac.dmg

Egh, scratch that, I can reproduce weirdness, at the very least.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

First to review wins!

I had this in my patch for the "undo close tab" bug but the patch worked fine without it. It seems that the change was necessary after all :)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 755021 [details] [diff] [review]
Patch

Oh yeah, totally. How did that stuff get down there after the beforecustomization event fires? :/

I have a sneaking suspicion that was my bad. r=me.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/projects/ux/rev/b7ab1c274cf5

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/b7ab1c274cf5