Closed Bug 876766 Opened 7 years ago Closed 7 years ago

Build warning for out-of-order init list in PeerConnectionMedia.h

Categories

(Core :: WebRTC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

(Whiteboard: [WebRTC][blocking-webrtc-][qa-])

Attachments

(1 file)

New GCC warning, which says (pruned):
> PeerConnectionMedia.h:232:24: warning: 'sipcc::RemoteSourceStreamInfo::mParent' will be initialized after [-Wreorder]
> PeerConnectionMedia.h:227:34: warning:   'mozilla::DOMMediaStream::TrackTypeHints sipcc::RemoteSourceStreamInfo::mTrackTypeHints' [-Wreorder]
> PeerConnectionMedia.h:206:1: warning:   when initialized here [-Wreorder]

Appears to have been introduced by bug 873888.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Whiteboard: [WebRTC][blocking-webrtc-]
Attached patch fixSplinter Review
This fixes it -- just shifting mTrackTypeHints(0) to the beginning of the init list, since it's declared as the first member-var in the class.
Attachment #754892 - Flags: review?(ethanhugg)
Comment on attachment 754892 [details] [diff] [review]
fix

Review of attachment 754892 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this.  I should have caught it with the earlier patch.
Attachment #754892 - Flags: review?(ethanhugg) → review+
No problem. Thanks for the quick review!

There's a bit of a mozilla-inbound backlog right now, so I'm tagging this as checkin-needed so it can ride along with something instead of getting its own tbpl cycle.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/85de1d79d8be
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Whiteboard: [WebRTC][blocking-webrtc-] → [WebRTC][blocking-webrtc-][qa-]
You need to log in before you can comment on or make changes to this bug.