876825 - Mixed LTR & RTL content support in text input fields and textarea

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Binyamin]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.94 Safari/537.36

Steps to reproduce:

You can fix this issue on adding dir=auto for the textarea field.

Comment 1

[Binyamin]

Issue under Geeksphone Kernel https://github.com/gp-b2g/gp-peak-kernel/issues/12

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

:yxl, any clue?

Comment 3

[Yuan Xulei [:yxl] (Leave from May 18)]

I've no experience of right-to-left support and I'm trying to understand what the problem is.

Comment 4

[Binyamin]

Right-to-left means aligned right. For example on typing in Hebrew it must affect RTL and LTR while typing in English. Tye easy standard solution for textarea <textarea dir=auto></textarea>, test case http://jsbin.com/IrugemE/1/edit

Comment 5

[Binyamin]

An updated test-case http://jsbin.com/IrugemE/2/edit

Comment 6

[Yuan Xulei [:yxl] (Leave from May 18)]

@Binyamin, thanks for your explanation and test cases. Then how do you expect us to fix this issue? Will adding|dir=auto| for all text areas be enough, or should we do extra work?

Comment 7

[Binyamin]

Yes, adding "dir=auto" must fix the issue.
Also replace dir=ltr/rtl with dir=auto from any user customizable holder (<p>, <div>, <input>, <textarea>, etc.), like SMS messages, Contacts, etc. to affect LTR/RTL automatically. For example you can avoid "dir" from <input type=email/tel/number> since it always must affect default LTR (email can contain just Latin characters, numbers has left-to-right writing also in right-to-left).

W3C summarized test results:
4 failes test cases - http://www.w3.org/International/tests/html5/the-dir-attribute/results-dir-auto
4 failes test cases - http://www.w3.org/International/tests/html-css/bidi-html5/results-bidi-html5

This W3C test cases https://github.com/w3c/web-platform-tests/tree/master/html/dom/elements/global-attributes seems Firefox 24 stable passes fine.

Comment 8

[Binyamin]

Yes, adding "dir=auto" must fix the issue.
Also replace dir=ltr/rtl with dir=auto from any user customizable holder (<p>, <div>, <input>, <textarea>, etc.), like SMS messages, Contacts, etc. to affect LTR/RTL automatically. For example you can avoid "dir" from <input type=email/tel/number> since it always must affect default LTR (email can contain just Latin characters, numbers has left-to-right writing also in right-to-left).

W3C summarized test results:
4 failed test cases - http://www.w3.org/International/tests/html5/the-dir-attribute/results-dir-auto
4 failed test cases - http://www.w3.org/International/tests/html-css/bidi-html5/results-bidi-html5

This W3C test cases https://github.com/w3c/web-platform-tests/tree/master/html/dom/elements/global-attributes seems Firefox 24 stable passes fine.

Comment 9

[Ahmed Nefzaoui [:Nefzaoui]]

CC'ing Mohammad Dirar who wants to take this and actually helping him get his first bug done.
PS: I will file another bug for non editable elements.

Comment 10

[Mohammad Otoum]

Attachment: Pull Request to Bug 876825

I'm new here Can you please help me get this merged, review please?

Comment 11

[Stephany Wilkes]

Comment on attachment 8413431 [details] [review]
Pull Request to Bug 876825

Fabien is not in. Flagging Rudy to see if we can get this reviewed and landed. Would be really great to have for Arabic support.

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

This seems to be a general issue that is across multiple apps, so change the component.

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8413431 [details] [review]
Pull Request to Bug 876825

Tim, could you please help review this since I don't think I could review a Gaia-wide patch like this.
Thank you.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8413431 [details] [review]
Pull Request to Bug 876825

This need rebase. I can rubberstamp r+ once rebased.

Comment 15

[Stephany Wilkes]

How is the rebase coming? Can we this go back up for review? now? Thanks!

Comment 16

[Stephany Wilkes]

What is the status here? Would like to get this into 2.0 if at all possible.

Comment 17

[Ahmed Nefzaoui [:Nefzaoui]]

Taking after a little chat with Mohamad.
Will get a PR ready ASAP.

Comment 18

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: Github pull-request

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/859c26a147d21f26859c17511d3cbb92f4e4a881

Comment 20

[Stephany Wilkes]

Great news. Thanks, all!

Comment 21

[Andreas Gal :gal]

Lets try to uplift this to 1.4 for Dolphin.

Comment 22

[Stephany Wilkes]

Flagging Rudy and Bruce on the uplift request in comment #21, as I know it came up in email discussion.

Comment 23

[Bruce Huang [:bhuang] (inactive)]

(In reply to Andreas Gal :gal from comment #21)
> Lets try to uplift this to 1.4 for Dolphin.

Ahmed, do you know the level of effort needed to rebase to 1.4?

Comment 24

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Ahmed,

Could you also help uplifting your patch to v1.4?
I would expect there will be conflicts, so this could be transformed into a branch-specific patch for v1.4.

Thank you.

Comment 25

[Ahmed Nefzaoui [:Nefzaoui]]

Sure, I'll get a 1.4-specific patch ready.

Comment 26

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: [v1.4 ] Github Pull-request

Same work, for v1.4

Comment 27

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/40c01c1330dd5dc5f5cfb547b7dc7712276e2cd5
v1.4: https://github.com/mozilla-b2g/gaia/commit/42a1c84c2122fd772e4151d3ff822cddd2a040fa

Comment 28

[Peter Bylenga [:PBylenga]]

Mass Edit: adding the [rtl-meta]

Comment 29

[Sue]

Hi Binyamin,
Could you provide the detailed reproduce steps or video for me to verify this bug? Thanks!

Comment 30

[Binyamin]

There is nothing to verify. If applied "dir=auto" it has to have correct bidi direction.
There is another W3C spec bug for placeholder bidi https://www.w3.org/Bugs/Public/show_bug.cgi?id=17814, hopefully W3C will reconsider to fix it.

Comment 31

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue is verified fixed on Flame 3.0 and Flame 2.2

The user can correctly type in both RTL and LTR languages in a the same text field and the text will appear properly

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Shallow Flash)
Build ID: 20150205010209
Gaia: 2b83a6d5d1185a438b5bbd287497ac2743b501db
Gecko: 34a66aaaca81
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Shallow Flash)
Build ID: 20150205002503
Gaia: c2047a46e29696238e9b4c9caaba47736421449a
Gecko: adfba0a07e9b
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0