876907 - Add test for tab.open inNewWindow + onOpen combination

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

There is no test for this snippet atm:

tabs.open({
  url: 'http://mozilla.org',
  inNewWindow: true,
  onOpen: function() {
    // test that this is called..
  }
})

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1010

Pointer to Github pull-request

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 755035 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1010

May I send you reviews now Jordan?

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 755035 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1010

Looks good!

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/0fba836d548be728ded3d693ece8651e3462b46f
Bug 876907: adding a test for the tabs.open with onOpen and inNewWindow options combination

https://github.com/mozilla/addon-sdk/commit/1b7d428857bda6bdd07ca11cfd91143e26c61c21
Merge pull request #1010 from erikvold/876907

Fix Bug 876907: adding a test for the tabs.open with onOpen and inNewWindow r=@jsantell