876937 - Allow export URL's to load if there is a slash at the end

Status: RESOLVED FIXED

(Webmaker Graveyard :: Make Valet, defect)

Description

[Jacob [:Jacob]]

Currently, this link won't load properly - i.e. http://popcorn.webmadecontent.org/13w4/

because there is a slash at the end.

Works if you remove the slash - i.e. http://popcorn.webmadecontent.org/13w4 - but we should allow it to work with a slash because sometimes it shows up when sharing.

Discovered this from a blog post that had broken Popcorn Maker links because publisher had a slash at the end of their shared URL

Comment 1

[Jon Buckley [:jbuck]]

Hm, doing this would require writing two files to S3...

I dunno, I think I want to RESOLVED WONTFIX this because it's not really the same URL.

How do people add an extra / there I wonder...

Comment 2

[David Humphrey (:humph)]

I suspect one might think this is a dir vs a file, and add the / so you get the /index.html inside (obviously wrong, but that's my guess).

One data point, YouTube supports this:

http://www.youtube.com/v/GP53b__h4ew vs http://www.youtube.com/v/GP53b__h4ew/

Jon, is it possible for nginx to eat trailing `/`s before it gets to S3?  If so, great.  If not, let's WONTFIX this.  I agree that we don't want to write another file to S3 for this.

Comment 3

[Jon Buckley [:jbuck]]

Possibly! Something to look into.

Comment 4

[Jon Buckley [:jbuck]]

Just dropping this here to look at later: http://www.osbmedia.com/blog/view/adding-a-trailing-slash-to-your-urls-on-nginx

Comment 5

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/make-valet/pull/3

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/make-valet

https://github.com/mozilla/make-valet/commit/2162f58253e588239bd6e742af12392bfb6a59ea
Fix bug 876937 - Strip trailing slashes