Closed Bug 876944 Opened 8 years ago Closed 7 years ago

CustomizeMode.jsm needs to handle onWidgetCreated/onWidgetDestroyed events

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: Unfocused, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P4][Australis:M9])

Attachments

(1 file)

CustomizeMode.jsm needs to handle the cases when an API widgets is created or destroyed, via the onWidgetCreated and onWidgetDestroyed events.

Note also bug 876926, which probably necessitates the need for a onWidgetDestroying event.
Not taking this for Australis:M7.
What's the impact of not handling this? Don't know how to assign a priority otherwise.
Flags: needinfo?(bmcbride)
Neither case should be common. Not handling widgets being created should just be an annoyance (so, something we want to fix, but not a priority IMO).

However, not handling widgets being destroyed could break the browser window - so I think that at least should be fixed before release. That could happen in any of the following instances:
* add-on updated
* add-on disabled/uninstalled (via another window - unlikely, but possible)
* add-on blocklisted
* changing add-on references while customizing (both are "customizing my browser", so I can imagine people doing this)

So, I think we can be pretty minimal with the fix here and still address the main issue. And just leave everything else to a followup when we have time.
Flags: needinfo?(bmcbride)
Whiteboard: [Australis:M?] → [Australis:P4]
This should do. I needed a notification after the node had been added to the windows, should it have a placement already, so I added one. Feel free to nitpick naming. :-)
Attachment #820940 - Flags: review?(bmcbride)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #820940 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/projects/ux/rev/2669b682cd34
Whiteboard: [Australis:P4] → [Australis:P4][Australis:M9][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/2669b682cd34
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4][Australis:M9][fixed-in-ux] → [Australis:P4][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.