Closed Bug 876954 Opened 8 years ago Closed 8 years ago

[mozillapulse] Basic tests

Categories

(Webtools :: Pulse, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mcote, Unassigned)

Details

Attachments

(1 file)

Before switching out the RabbitMQ client (bug 623305), it would be nice to have some basic tests.
This adds some basic tests.  They rely on a RabbitMQ server, so a Vagrantfile has been added to ease setup.  See test/README.md for details.

I also added license headers to all files, license info to setup.py, and a small change to consumers.GenericConsumer to facilitate the tests.

jgriffin is most familiar with this code to I asked him for review.  dkl, I requested feedback from you mostly to keep you in the loop & help you get a feel for the code, but if you have any comments, please go right ahead and mention them. :)
Attachment #755079 - Flags: review?(jgriffin)
Attachment #755079 - Flags: feedback?(dkl)
Comment on attachment 755079 [details] [diff] [review]
Basic tests, add license headers

Review of attachment 755079 [details] [diff] [review]:
-----------------------------------------------------------------

Looks awesome!  I didn't actually run it though.

Since it's such a critical piece of metadata, might be a good idea to verify the message's routing key as well, e.g.,

self.assertEqual(msg.routing_key, received_data['_meta']['routing_key'])
Attachment #755079 - Flags: review?(jgriffin) → review+
Good call.  Added that line.  Also switched the deprecated usage of assertEquals() to assertEqual(), and changed "payload" to "received_payload" for consistency and clarity.
Attachment #755079 - Flags: feedback?(dkl) → feedback+
https://hg.mozilla.org/automation/mozillapulse/rev/54ecebb1a9c8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.