876954 - [mozillapulse] Basic tests

Status: RESOLVED FIXED

(Webtools :: Pulse, defect)

Description

[Mark Côté [:mcote]]

Before switching out the RabbitMQ client (bug 623305), it would be nice to have some basic tests.

Comment 1

[Mark Côté [:mcote]]

Attachment: Basic tests, add license headers

This adds some basic tests.  They rely on a RabbitMQ server, so a Vagrantfile has been added to ease setup.  See test/README.md for details.

I also added license headers to all files, license info to setup.py, and a small change to consumers.GenericConsumer to facilitate the tests.

jgriffin is most familiar with this code to I asked him for review.  dkl, I requested feedback from you mostly to keep you in the loop & help you get a feel for the code, but if you have any comments, please go right ahead and mention them. :)

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 755079 [details] [diff] [review]
Basic tests, add license headers

Review of attachment 755079 [details] [diff] [review]:
-----------------------------------------------------------------

Looks awesome!  I didn't actually run it though.

Since it's such a critical piece of metadata, might be a good idea to verify the message's routing key as well, e.g.,

self.assertEqual(msg.routing_key, received_data['_meta']['routing_key'])

Comment 3

[Mark Côté [:mcote]]

Good call.  Added that line.  Also switched the deprecated usage of assertEquals() to assertEqual(), and changed "payload" to "received_payload" for consistency and clarity.

Comment 4

[Mark Côté [:mcote]]

https://hg.mozilla.org/automation/mozillapulse/rev/54ecebb1a9c8