877006 - A widget with an invalid view should not break all of CustomizableUI

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

When buildWidget detects a widget with a view, and the elemnt for the view can't be found it throws an exception - sadly, this breaks all of CustomizableUI. It, er, shouldn't do that.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Not taking this for Australis:M7.

Comment 2

[:Gijs (he/him)]

Attachment: Patch

Something like this? :-)

Comment 3

[:Gijs (he/him)]

Attachment: Test

Annnd a test. For the todo, see bug 891926, which I just filed. I'll add a patch there and s/todo/ok/. :-)

Comment 4

[:Gijs (he/him)]

Comment on attachment 773336 [details] [diff] [review]
Test

>+  requestLongerTimeout(5);

Self-nit: this shouldn't be here (too eager copying from another test, oops!)

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 773331 [details] [diff] [review]
Patch

Review of attachment 773331 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/src/CustomizableUI.jsm
@@ +802,1 @@
>            ERROR("Could not find the view node with id: " + aWidget.viewId);

Nit: Since you're here, include the widget id in this log message?

Comment 6

[:Gijs (he/him)]

Folded and pushed: https://hg.mozilla.org/projects/ux/rev/757b3bbe3c63

Comment 7

[:Gijs (he/him)]

This was backed out yesterday: https://hg.mozilla.org/projects/ux/rev/a8a320338f33

Comment 8

[:Gijs (he/him)]

Relanded with a fix in the tests as https://hg.mozilla.org/projects/ux/rev/56af4ca8e542

using defaultArea for the widget breaks because it sticks around in the default placements after a reset. I'll file a bug on that in the next few hours.

Comment 9

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/56af4ca8e542