877029 - add a crashtest to ensure UpdateGlyphPositioning aForceGlobalTransform is being used correctly

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

One use of nsSVGTextFrame(2)::UpdateGlyphPositioning's aForceGlobalTransform argument is to ensure we don't call GetCanvasTM() on a <marker> ancestor of a <text>, which would crash if we are not currently painting the marker (due to the marker frame having mMarkedFrame == nullptr).  I couldn't find a crashtest for this, so let's add one.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 2

[Robert Longson [:longsonr]]

bug 847139 seems to do the same thing doesn't it?

Comment 3

[Cameron McCormack (:heycam)]

Oh, hmm.  So FindCloserFrameForSelection grew an early return if the frame is non-display, so the test in that bug doesn't crash any more (if we incorrectly passed in true) since we wouldn't get to the UpdateGlyphPositioning call.

Do you think it is still worth adding this test?

Comment 4

[Cameron McCormack (:heycam)]

Although given in bug 877035 aForceGlobalTransform will disappear...

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 755144 [details] [diff] [review]
patch

I guess so in that case.

Comment 6

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6af9d5797340

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6af9d5797340