87704 - JS warnings about winhooks at startup

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Simon Fraser [no longer active]]

I get these warnings at startup:

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1326: reference to undefined 
property Components.classes['@mozilla.org/winhooks;1']

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1326: reference to undefined 
property Components.classes['@mozilla.org/winhooks;1']

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1326: reference to undefined 
property Components.classes['@mozilla.org/winhooks;1']

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1326: reference to undefined 
property Components.classes['@mozilla.org/winhooks;1']

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1326: reference to undefined 
property Components.classes['@mozilla.org/winhooks;1']

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1326: reference to undefined 
property Components.classes['@mozilla.org/winhooks;1']

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1326: reference to undefined 
property Components.classes['@mozilla.org/winhooks;1']

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1326: reference to undefined 
property Components.classes['@mozilla.org/winhooks;1']

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1326: reference to undefined 
property Components.classes['@mozilla.org/winhooks;1']

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1326: reference to undefined 
property Components.classes['@mozilla.org/winhooks;1']

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1326: reference to undefined 
property Components.classes['@mozilla.org/winhooks;1']

presumably because the winhooks interface is not present on Mac. Although benign, 
it would be good to eliminate this warning.

Comment 1

[Simon Fraser [no longer active]]

Other new JS warnings in that file:

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1003: reference to undefined 
property Components.classes['@mozilla.org/xpcom/leakdetector;1']

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1102: reference to undefined 
property Components.classes['@mozilla.org/urlwidget;1']

Comment 2

[sairuh (rarely reading bugmail)]

i also see this in my 6/21 linux debug. don't see this w/verif bits.

Comment 3

[Colin Blake]

Also seen on OpenVMS debug build.

Comment 4

[jag (Peter Annema)]

Attachment: [patch] Hush 'em up.

Comment 5

[jag (Peter Annema)]

It's interesting that we're getting so many warnings when there's only one line,
which is only called once.

Brendan, shaver, any idea why that could be?

Comment 6

[jag (Peter Annema)]

Oh, doh, forgot about the leakdetector and urlwidget (that's still in there?).
New patch coming up.

Comment 7

[jag (Peter Annema)]

Attachment: [patch] get rid of strict warnings

Comment 8

[jag (Peter Annema)]

Attachment: [patch] Also set LeakDetector.prototype in else case.

Comment 9

[Bradley Baetz (:bbaetz)]

r=bbaetz

Comment 10

[Brendan Eich [:brendan]]

sr=[e-mail]

/be

Comment 11

[jag (Peter Annema)]

Thanks for the sr brendan :-) But do you have any idea why we'd see 11 strict JS
warnings for the one same line?

Comment 12

[Brendan Eich [:brendan]]

Sure -- it's a runtime warning.  That statement must have executed 11 times.  Do
you know why that might happen?

/be

Comment 13

[jag (Peter Annema)]

Well, the code is executed only once.

I've modified that function like this:

var foopyCount = 0;
var barCount = 0;
function checkForDefaultBrowser()
{
  foopyCount++;
  try {
    Components.classes["@mozilla.org/winhooks;1"]
              .getService(Components.interfaces.nsIWindowsHooks)
              .checkSettings(window);
  } catch(e) {
    barCount++;
  }
  dump("Foopy: "+foopyCount+", bar: "+barCount+"...\n");
}

Which results in this chunk of output at startup:

JavaScript strict warning: 
chrome://navigator/content/navigator.js line 1326: reference to undefined
property Components.classes['@mozilla.org/winhooks;1']

[Repeat strict warning 10 times, see original post for an example ;-)]

Foopy: 1, bar: 1...

Comment 14

[Brendan Eich [:brendan]]

I repeat that the JS engine does not report errors redudantly.  Can you debug a
bit, see who is?  Maybe it's XPConnect.

/be

Comment 15

[jag (Peter Annema)]

I guess xpconnect. It iterates over a bunch of listeners trying to QI them to an
onload listener, the QI fails (it looks for the "QueryInterface" property on the
object), which triggers the strict js warning printing code. This apparently
just prints out the last warning it got. Let me file a new bug on this :-)

Comment 16

[jag (Peter Annema)]

Checked in, marking fixed.

Comment 17

[sairuh (rarely reading bugmail)]

i no longer see these warnings with linux moz debug from last night.