Closed Bug 877132 Opened 6 years ago Closed 6 years ago

System integration dialog broken - Components.classes["@mozilla.org/mail/shell-service;1"] reference to undefined property

Categories

(Thunderbird :: Build Config, defect)

defect
Not set

Tracking

(thunderbird23 fixed)

VERIFIED FIXED
Thunderbird 24.0
Tracking Status
thunderbird23 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch The fixSplinter Review
Trying to start the latest Thunderbird build on my desktop I'm getting:

Components.classes["@mozilla.org/mail/shell-service;1"] reference to undefined property

It appears in bug 859125 - http://hg.mozilla.org/comm-central/rev/50dcb67013a5#l1.47 - we lost mailcomps being included into the XUL build.

Fixing this fixes the system integration dialog as well, which would basically do nothing if this service isn't defined.
Attachment #755303 - Flags: review?(Pidgeot18)
Comment on attachment 755303 [details] [diff] [review]
The fix

Too much copy-and-paste on my part. Sorry about that. (SeaMonkey just compiles its shell service with external linkage in a separate library.)
Attachment #755303 - Flags: feedback+
Comment on attachment 755303 [details] [diff] [review]
The fix

Review of attachment 755303 [details] [diff] [review]:
-----------------------------------------------------------------

drive by surprise review!
Attachment #755303 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/comm-central/rev/d0c1abdb3487
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
I think Aurora is affected as well.
Verified fixed on trunk.
Also verified that is indeed needed on:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Thunderbird/23.0a2 ID:20130530004001 CSet: 7bc2fd64ec45
Status: RESOLVED → VERIFIED
Comment on attachment 755303 [details] [diff] [review]
The fix

a=me
Attachment #755303 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.