877132 - System integration dialog broken - Components.classes["@mozilla.org/mail/shell-service;1"] reference to undefined property

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Trying to start the latest Thunderbird build on my desktop I'm getting:

Components.classes["@mozilla.org/mail/shell-service;1"] reference to undefined property

It appears in bug 859125 - http://hg.mozilla.org/comm-central/rev/50dcb67013a5#l1.47 - we lost mailcomps being included into the XUL build.

Fixing this fixes the system integration dialog as well, which would basically do nothing if this service isn't defined.

Comment 1

[[e-mail]]

Comment on attachment 755303 [details] [diff] [review]
The fix

Too much copy-and-paste on my part. Sorry about that. (SeaMonkey just compiles its shell service with external linkage in a separate library.)

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 755303 [details] [diff] [review]
The fix

Review of attachment 755303 [details] [diff] [review]:
-----------------------------------------------------------------

drive by surprise review!

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/d0c1abdb3487

Comment 4

[Joe Sabash [:JoeS1]]

I think Aurora is affected as well.

Comment 5

[Joe Sabash [:JoeS1]]

Verified fixed on trunk.
Also verified that is indeed needed on:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Thunderbird/23.0a2 ID:20130530004001 CSet: 7bc2fd64ec45

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 755303 [details] [diff] [review]
The fix

a=me

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/c75bd0c80e55