Closed Bug 877153 Opened 7 years ago Closed 7 years ago

adjust the appearance of mailviews picker in the Thunderbird toolbar

Categories

(Thunderbird :: Theme, defect)

All
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 25.0

People

(Reporter: aceman, Assigned: Paenglab)

Details

(Keywords: polish)

Attachments

(3 files, 1 obsolete file)

Bug 861933 unified the height of the mailviews picker with the folder location picker in the Thunderbird toolbar in Windows 7. This should be done for other OSes as needed. Also, the "Tags" and "Custom views" are indented in the list. This was changed for Win7 but not other OSes. Screenshot from Win XP attached.
Attached patch patch (obsolete) — Splinter Review
This patch needs bug 876222 applied first.

OS X looks good.

On Linux I gave in locationFolders menulist the items in subfolders 3px padding on the left to give them the same gap to the edges as the main menu in this menulist have. Aceman, please can you check this if it also looks good on your Linux distribution?

On WinXP I used some rules from mailWindow1-aero.css and removed them there.
 - fixed is the height two menulists
 - the indented menus are also fixed
 - the items left and right gap to the menu edges are now all 5px
 - the sub-menuitems in viewPicker are 2px taller to not look so condensed
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #756114 - Flags: ui-review?(mconley)
Attachment #756114 - Flags: review?(mconley)
I am not sure I see any difference. Where should I look?
In locationsFolders all menu/menuitems in all menus and submenus should have the same gap between the text and the border on the left.
I still do not see what the gain is. The padding on the left is now much bigger than without the patch. Is that positive?
Attached patch patchSplinter Review
On Linux the first level has also the id folderLocationPopup. I added menu > to the selectors to apply only beginning with the second folderLocationPopup. Now all items have the same padding to the icons of 5px.
Attachment #756114 - Attachment is obsolete: true
Attachment #756114 - Flags: ui-review?(mconley)
Attachment #756114 - Flags: review?(mconley)
Attachment #757568 - Flags: ui-review?(mconley)
Attachment #757568 - Flags: review?(mconley)
Comment on attachment 757568 [details] [diff] [review]
patch

Review of attachment 757568 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Richard!
Attachment #757568 - Flags: ui-review?(mconley)
Attachment #757568 - Flags: ui-review+
Attachment #757568 - Flags: review?(mconley)
Attachment #757568 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/6cdc08bdc5fc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 25.0
Looks great on XP, thank.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.