877153 - adjust the appearance of mailviews picker in the Thunderbird toolbar

Status: VERIFIED FIXED

(Thunderbird :: Theme, defect)

Description

[:aceman]

Attachment: screenshot with marked height difference

Bug 861933 unified the height of the mailviews picker with the folder location picker in the Thunderbird toolbar in Windows 7. This should be done for other OSes as needed. Also, the "Tags" and "Custom views" are indented in the list. This was changed for Win7 but not other OSes. Screenshot from Win XP attached.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

This patch needs bug 876222 applied first.

OS X looks good.

On Linux I gave in locationFolders menulist the items in subfolders 3px padding on the left to give them the same gap to the edges as the main menu in this menulist have. Aceman, please can you check this if it also looks good on your Linux distribution?

On WinXP I used some rules from mailWindow1-aero.css and removed them there.
 - fixed is the height two menulists
 - the indented menus are also fixed
 - the items left and right gap to the menu edges are now all 5px
 - the sub-menuitems in viewPicker are 2px taller to not look so condensed

Comment 2

[:aceman]

I am not sure I see any difference. Where should I look?

Comment 3

[Richard Marti (:Paenglab)]

In locationsFolders all menu/menuitems in all menus and submenus should have the same gap between the text and the border on the left.

Comment 4

[:aceman]

Attachment: screenshot on Linux with the patch

I still do not see what the gain is. The padding on the left is now much bigger than without the patch. Is that positive?

Comment 5

[Richard Marti (:Paenglab)]

Attachment: patch

On Linux the first level has also the id folderLocationPopup. I added menu > to the selectors to apply only beginning with the second folderLocationPopup. Now all items have the same padding to the icons of 5px.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 757568 [details] [diff] [review]
patch

Review of attachment 757568 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Richard!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/6cdc08bdc5fc

Comment 8

[:aceman]

Looks great on XP, thank.