Closed
Bug 877157
Opened 12 years ago
Closed 12 years ago
Implement new VIVO SMS protocol for checking balance
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect)
Tracking
(blocking-b2g:leo+, b2g18? fixed)
RESOLVED
FIXED
| blocking-b2g | leo+ |
People
(Reporter: salva, Assigned: salva)
References
Details
Attachments
(1 file)
|
257 bytes,
text/html
|
jmcf
:
review+
bajaj
:
approval-gaia-v1+
|
Details |
VIVO has changed the protocol to check balance. It is yet based on SMS but now the message being sent must be created dynamically to include a timestamp and other variable data.
See details in bug 875330.
| Assignee | ||
Updated•12 years ago
|
tracking-b2g18:
--- → ?
QA Contact: carlos.martinez
| Assignee | ||
Comment 1•12 years ago
|
||
Attachment #755523 -
Flags: review?(jmcf)
Comment 2•12 years ago
|
||
Comment on attachment 755523 [details]
New VIVO SMS protocol
good work Salva
Attachment #755523 -
Flags: review?(jmcf) → review+
| Assignee | ||
Comment 3•12 years ago
|
||
Master: d2ad0f1a5a6be8a2d6df721ba3c2b33e037c423b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 4•12 years ago
|
||
Comment on attachment 755523 [details]
New VIVO SMS protocol
This can be considered as the follow up for bug 875695 so, the same reasons apply. Renominating to leo?
Bug caused by (feature/regressing bug #): bug 875330 - this is the actual implementation of the new Vivo protocol.
User impact if declined: high - the application will cease to work
Testing completed: yes - and new unit tests to verify the protocol added
Risk to taking this patch (and alternatives if risky): low - despite the bunch of code added. It has been tested.
String or UUID changes made by this patch: none
Attachment #755523 -
Flags: approval-gaia-v1?
| Assignee | ||
Updated•12 years ago
|
blocking-b2g: --- → leo?
Updated•12 years ago
|
Attachment #755523 -
Flags: approval-gaia-v1? → approval-gaia-v1+
Updated•12 years ago
|
blocking-b2g: leo? → leo+
Comment 5•12 years ago
|
||
I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with:
git checkout v1-train
git cherry-pick -x -m1 d2ad0f1a5a6be8a2d6df721ba3c2b33e037c423b
<RESOLVE MERGE CONFLICTS>
git commit
Flags: needinfo?(salva)
| Assignee | ||
Comment 6•12 years ago
|
||
v1-train: 5534304aee934055f08f21ce93261ba2a596516a
status-b2g18:
--- → fixed
Flags: needinfo?(salva)
Updated•12 years ago
|
Flags: in-moztrap-
You need to log in
before you can comment on or make changes to this bug.
Description
•