877167 - [SMS][Regression][v1-train] Edit mode styles are broken. 'Red square' sourrounding the text should be removed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

Attachment: Issue

Comment 1

[Julien Wajsberg [:julienw]]

This is not on master, probably a left-over from debugging problems on the v1-train branch ?

Comment 2

[Maria Angeles Oteo (:oteo)]

it could be, we are reproducing it in v1-train branch.

Comment 3

[Corey Frang [:gnarf]]

Hrm, I wonder what didn't get uplifted to v1-train.  Any thoughts here Mike?

Comment 4

[Mike Pennisi [:jugglinmike]]

I did some digging and found this:

The change in question was submitted for Bug 840055.

The commit in `master` is here:

https://github.com/mozilla-b2g/gaia/commit/b9b9e9#L3L446

The above commit removes the following CSS:

  .edit #messages-container[data-type="list"] li.selected p {
    border: 0.2rem solid #B90000;
  }

But that change is not present in the uplifted commit:

https://github.com/mozilla-b2g/gaia/commit/9d452e6#L3L446

I'll get to work creating a patch that re-applies the missing changes from the original commit.

Comment 5

[Borja Salguero [:borjasalguero]]

Mike, https://bugzilla.mozilla.org/show_bug.cgi?id=840055 was uplifted, so this issue should be fixed... could you investigate this (it was supposed to be uplifted here https://bugzilla.mozilla.org/show_bug.cgi?id=840055#c41)? Thanks!

Comment 6

[Mike Pennisi [:jugglinmike]]

Attachment: Remove outdated declaration blocks

This patch resolves the issue by increasing parity between `master` and `v1-train`. I identified the necessary changes by comparing the "sms.css" file between the two branches with the following command:

    git diff b9b9e9 9d452e6 style/sms.css

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 755624 [details] [diff] [review]
Remove outdated declaration blocks

works for me
r=me

thanks !

Comment 8

[Julien Wajsberg [:julienw]]

v1-train: 1cca9324d4444ad28c6fa99875e17abf7e8230be

Comment 9

[Julien Wajsberg [:julienw]]

(note: this was a v1-train-only fix to fix a bad uplift)

Comment 10

[Deepa Subramanian]

Issue does not repro anymore. The user does not see the "Red square" surrounding the text.

The defect is verified as fixed.
Environmental Variables
Leo Build ID: 20130807071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/11bb1b0eefff
Gaia: 60ca81600a080dae33058b0692ecaa213556c926
Platform Version: 18.1