877199 - Browser console's window title temporarily says "Web Console" before changing to "Browser console".

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Now that the error console is gone and the browser console has taken the Ctrl/Cmd-Shift-J keyboard shortcut, I'm noticing that after I press that shortcut, the browser console opens up in a separate window (as expected), but the window's title says "Web Console" for a second or two (or more, if my system's resources are being used elsewhere), before changing to "Browser Console".

I think it shouldn't do that, if at all possible.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Wes Kocher (:KWierso) from comment #0)
> Now that the error console is gone and the browser console...
To be clear, I don't think the "now that" part has anything to do with it. I just wasn't using the browser console often enough previously to notice this.

Comment 2

[Mihai Sucan [:msucan]]

Attachment: proposed fix

HUDService waits too long before it changes the browser console window title. I changed the code to do things earlier. This fixes the problem on my system. Please also test on yours and confirm the fix works for you.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=f036c227aa1c

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 755474 [details] [diff] [review]
proposed fix

Review of attachment 755474 [details] [diff] [review]:
-----------------------------------------------------------------

alrighty. worth a shot.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I still see a flash of "Web Console" before it displays "Browser Console". It might be a shorter amount of time than the current Nightly, or it might be that I tried it with my non-default profile, so it has less stuff in there slowing it down.

Comment 5

[Mihai Sucan [:msucan]]

Attachment: updated patch

Updated the patch to change the window title even earlier: in DOMContentLoaded, before any initialization happens.

I will land this patch as soon as I can.

Comment 6

[Mihai Sucan [:msucan]]

Landed in fx-team:
https://hg.mozilla.org/integration/fx-team/rev/1e40ab9ff736

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1e40ab9ff736