877235 - Removal of JS_GetGlobalObject from jsdContext::GetGlobalObject breaks firebug

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

See bug 871306 comment 15.

Comment 1

[Bobby Holley (:bholley)]

So, I think gabor's suggestion to cache the global at the right point could work. But Honza says that Firebug will stop depending on this stuff very soon (possibly this cycle). At the moment, the main reason I wanted to get rid of JS_GetGlobalObject was so that we could proceed on bug 865745. I can't imagine that we care about the interaction between Firebug and the frame message manager global, so I don't think that really conflicts here.

As such, if it's ok with everyone, I'm just going to use our little backdoor function to restore the old behavior here for the interim. Let's stay on track removing JSD. :-)

Comment 2

[Bobby Holley (:bholley)]

Attachment: Use the default global for just a little bit longer in JSD. v1

Comment 3

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 755461 [details] [diff] [review]
Use the default global for just a little bit longer in JSD. v1

Review of attachment 755461 [details] [diff] [review]:
-----------------------------------------------------------------

Well if it's not too urgent to remove this backdoor function then sure. I'm fine with not digging into JSD too much if we don't have to.

Comment 4

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3bead9d0a8a0

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thank you guys for the support I appreciate that!

Honza

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3bead9d0a8a0