Closed
Bug 877298
Opened 11 years ago
Closed 11 years ago
Move devtools globals to loader creation
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: dcamp, Assigned: dcamp)
References
Details
Attachments
(1 file)
2.97 KB,
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
Rather than main.js poking globals into the loader, let's just add them to loader initialization. While we're at it, make toolkit/loader an explicitly-provided module (like the default jetpack loader does), because it doesn't like to be loaded as a commonjs module.
Attachment #755536 -
Flags: review?(jwalker)
Updated•11 years ago
|
Attachment #755536 -
Flags: review?(jwalker) → review+
Assignee | ||
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/06b9e8ebf45b
Assignee: nobody → dcamp
Whiteboard: [fixed-in-fx-team]
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/06b9e8ebf45b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•