Closed
Bug 877305
Opened 11 years ago
Closed 11 years ago
Remove erroneous comma & var issues from Unit-Tests
Categories
(Webmaker Graveyard :: Login, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sedge, Assigned: igoryen)
Details
(Whiteboard: c=login u=dev)
Attachments
(1 file, 2 obsolete files)
In the Unit tests file (test.js), the helper function `apiHelper` has a comma where a semi-colon should be: `callback = callback || function() {},`
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #756152 -
Flags: review?(kieran.sedgwick)
Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 756152 [details]
Replaced comma with a semicolon at the end of the statement
I have a question for you in the PR, so take a peek. R- for now.
Also, when posting an attachement (or flagging for review) make sure to paste the URL in the comment box as well. It makes it easier for the reviewer to get to your code. (its a bugzilla thing...)
Attachment #756152 -
Flags: review?(kieran.sedgwick) → review-
Reporter | ||
Updated•11 years ago
|
Summary: Remove erroneous comma from Unit-Tests → Remove erroneous comma & var issues from Unit-Tests
Reporter | ||
Comment 3•11 years ago
|
||
Please attach a link to the pull request instead of the commit.
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #757567 -
Flags: review?(kieran.sedgwick)
Assignee | ||
Comment 5•11 years ago
|
||
https://github.com/mozilla/login.webmaker.org/pull/76
Attachment #756152 -
Attachment is obsolete: true
Attachment #757567 -
Attachment is obsolete: true
Attachment #757567 -
Flags: review?(kieran.sedgwick)
Attachment #758157 -
Flags: review?(kieran.sedgwick)
Comment 6•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/login.webmaker.org https://github.com/mozilla/login.webmaker.org/commit/89b5be21b700cb17d521040d8d30b389c9ad9a5a [bug877305] Replaced the erroneous comma; added the missing var https://github.com/mozilla/login.webmaker.org/commit/9f6637e813984ceda5349bc4d99bf73cf09a155b Merge pull request #76 from igoryen/bug877305 [bug877305] Replaced the comma at the end of the statement with a semico...
Reporter | ||
Comment 7•11 years ago
|
||
Comment on attachment 758157 [details] [review] PR - https://github.com/mozilla/login.webmaker.org/pull/76 Good work!
Attachment #758157 -
Flags: review?(kieran.sedgwick) → review+
Reporter | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•11 years ago
|
||
(In reply to Kieran Sedgwick (:sedge) from comment #7) > Comment on attachment 758157 [details] [review] > PR - https://github.com/mozilla/login.webmaker.org/pull/76 > > Good work! Thank you for your patience! ... :)
Updated•11 years ago
|
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•