If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

remove hyphenated names from puppetagain

RESOLVED FIXED

Status

Infrastructure & Operations
RelOps
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: arr, Assigned: arr)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 755555 [details] [diff] [review]
patch to remove hyphenated names

Both puppetagain and puppet320 have a few hyphenated names still kicking around that we should fix.  Be gentle, this is my first patch.  Hope I managed to get it right.  :}
Attachment #755555 - Flags: review?(dustin)
Comment on attachment 755555 [details] [diff] [review]
patch to remove hyphenated names

This looks like it's hit all of the includes of the hyphenated names, which is good.  However, it doesn't appear to rename the files.  For example, modules/tweaks/manifests/dev-ptmx.pp needs to be hg mv'd to modules/tweaks/manifests/dev_ptmx.pp, otherwise puppet won't be able to find it.  The resulting hg diff should look like

diff --git a/modules/tweaks/manifests/dev-ptmx.pp b/modules/tweaks/manifests/dev_ptmx.pp
--- a/modules/tweaks/manifests/dev-ptmx.pp
+++ b/modules/tweaks/manifests/dev_ptmx.pp
Attachment #755555 - Flags: review?(dustin) → review-
(Assignee)

Comment 2

4 years ago
Created attachment 755578 [details] [diff] [review]
fix hyphens, rename files, a clean up a few other syntax errors

Okay, I renamed the files, too.  I also cleaned up a few other small syntax issues.
Attachment #755578 - Flags: review?(dustin)
Attachment #755555 - Attachment is obsolete: true
Comment on attachment 755578 [details] [diff] [review]
fix hyphens, rename files, a clean up a few other syntax errors

Review of attachment 755578 [details] [diff] [review]:
-----------------------------------------------------------------

Good to commit with this fix.  Better wait until tomorrow to land it, though.

::: modules/tweaks/manifests/dev-ptmx.pp
@@ +1,4 @@
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +class tweaks::dev_ptmx {

This one needs a rename, too!
Attachment #755578 - Flags: review?(dustin) → review+
(Assignee)

Comment 4

4 years ago
Landed!
Assignee: dustin → arich
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Component: Server Operations: RelEng → RelOps
Product: mozilla.org → Infrastructure & Operations
You need to log in before you can comment on or make changes to this bug.