Closed
Bug 877334
Opened 11 years ago
Closed 11 years ago
remove hyphenated names from puppetagain
Categories
(Infrastructure & Operations :: RelOps: General, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arich, Assigned: arich)
Details
Attachments
(1 file, 1 obsolete file)
8.06 KB,
patch
|
dustin
:
review+
|
Details | Diff | Splinter Review |
Both puppetagain and puppet320 have a few hyphenated names still kicking around that we should fix. Be gentle, this is my first patch. Hope I managed to get it right. :}
Attachment #755555 -
Flags: review?(dustin)
Comment 1•11 years ago
|
||
Comment on attachment 755555 [details] [diff] [review] patch to remove hyphenated names This looks like it's hit all of the includes of the hyphenated names, which is good. However, it doesn't appear to rename the files. For example, modules/tweaks/manifests/dev-ptmx.pp needs to be hg mv'd to modules/tweaks/manifests/dev_ptmx.pp, otherwise puppet won't be able to find it. The resulting hg diff should look like diff --git a/modules/tweaks/manifests/dev-ptmx.pp b/modules/tweaks/manifests/dev_ptmx.pp --- a/modules/tweaks/manifests/dev-ptmx.pp +++ b/modules/tweaks/manifests/dev_ptmx.pp
Attachment #755555 -
Flags: review?(dustin) → review-
Assignee | ||
Comment 2•11 years ago
|
||
Okay, I renamed the files, too. I also cleaned up a few other small syntax issues.
Attachment #755578 -
Flags: review?(dustin)
Updated•11 years ago
|
Attachment #755555 -
Attachment is obsolete: true
Comment 3•11 years ago
|
||
Comment on attachment 755578 [details] [diff] [review] fix hyphens, rename files, a clean up a few other syntax errors Review of attachment 755578 [details] [diff] [review]: ----------------------------------------------------------------- Good to commit with this fix. Better wait until tomorrow to land it, though. ::: modules/tweaks/manifests/dev-ptmx.pp @@ +1,4 @@ > # This Source Code Form is subject to the terms of the Mozilla Public > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > +class tweaks::dev_ptmx { This one needs a rename, too!
Attachment #755578 -
Flags: review?(dustin) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Landed!
Assignee: dustin → arich
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Component: Server Operations: RelEng → RelOps
Product: mozilla.org → Infrastructure & Operations
You need to log in
before you can comment on or make changes to this bug.
Description
•