877394 - Display a throbber till content is loaded from makeAPI

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Brett Gaylor [:brett]]

Particularly with "stamps",its odd that the page loads before the contents of the gallery.  lets display a throbber while this is happening, similar to what we do with Popcorn Maker.

Comment 2

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker.org/pull/78

Please test this locally

Comment 3

[Dale Karp (:daleee)]

Comment on attachment 758236 [details] [review]
https://github.com/mozilla/webmaker.org/pull/78

I'm only seeing the loading animation when the page initially loads, not when selecting a new filter. Code looks good but it needs to show the animation whenever content is loaded from the API, not just on page load, nay?

Comment 4

[Dale Karp (:daleee)]

Comment on attachment 758236 [details] [review]
https://github.com/mozilla/webmaker.org/pull/78

r+, land this sucka

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/f40acc861966bc311400755a4376d09002586242
[bug 877394] Loading gif