Particularly with "stamps",its odd that the page loads before the contents of the gallery. lets display a throbber while this is happening, similar to what we do with Popcorn Maker.
Created attachment 758236 [details] [review] https://github.com/mozilla/webmaker.org/pull/78 Please test this locally
Attachment #758236 - Flags: review?(me)
Comment on attachment 758236 [details] [review] https://github.com/mozilla/webmaker.org/pull/78 I'm only seeing the loading animation when the page initially loads, not when selecting a new filter. Code looks good but it needs to show the animation whenever content is loaded from the API, not just on page load, nay?
Comment on attachment 758236 [details] [review] https://github.com/mozilla/webmaker.org/pull/78 r+, land this sucka
Attachment #758236 - Flags: review?(me) → review+
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/f40acc861966bc311400755a4376d09002586242 [bug 877394] Loading gif
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.