877454 - Add validation override

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Validation, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

The Marketplace packaged app uses a 64px data URI to make things easier for Firefox OS.

I'm blocked from making updates to the Marketplace packaged app because I get validation errors requiring a 128px-sized icon and that `data:` URIs are disallowed:

http://f.cl.ly/items/0t1I0Q3T3e3l1D3m0A0D/Screen%20Shot%202013-05-29%20at%203.13.04%20PM.png
http://f.cl.ly/items/1W3l3j05320A3f111w1x/Screen%20Shot%202013-05-29%20at%201.05.47%20PM.png

Can we please add an ability for admins to bypass validation à la the option we added to AMO? I could add a 128px-sized icon, and I filed bug 877419 and bug 877422 for the `data:` URI issue. Having this override would allow us to sneak other apps in (e.g., bug 876970).

Comment 1

[Wil Clouser [:clouserw]]

I thought basta alread did this but maybe I'm remembering AMO.  Basta - do we have this already?

Comment 2

[Matt Basta [:basta]]

No, and I actually didn't build the one for AMO either.

Comment 3

[Matt Basta [:basta]]

Marking this as WONTFIX now.

We rely on validation output for a bunch of different things, now. We could fake it in Zamboni, but that will cause other things down the line to fail or have invalid data (and the reason why the validator broke might cause other things to choke up, as well).

- Manifest parsing and extraction
- Permission usage
- Minimum requirement detection
- Cordova integration
- etc.

If the validation is erroring out, we should solve the issue that's causing the errors rather than plastering over it without solving the underlying problems. There's no circumstances that I'm aware of that the validator will block upload of an app for spurious reasons. We've done a heck of a lot of QA on the validator in the past three years and it's solid enough that when it does go out of its way to hard-block an app, it's for a good reason.