877467 - Remove "children" markup style from Prompt.jsm.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

I realized as I was writing some examples, the the children style of message I created for Prompt.jsm isn't ideal for what consumers probably want. Right now you can pass something like:

prompt.setSingleChoiceItems([
  { label: "Header", children: [
    {label: "Child"}
  ]}
]).show(function(data) {
  // data.button is the index of the clicked on item
});

Prompt.jsm converts the list from nested arrays a single flat array, where having an "index" for an item makes sense. In the nested for we return it doesn't. We either need to modify the return value we pass to the callback to indicate "Find the first item inside the first item", or just have callers pass in a flat list. I'm going to vote for the later.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch v1

So... I'm still fighting to not expose the normal syntax here. This makes setListItems just take a flat list. Items can have any of "header", "menu", or "child" attributes to control how they're styled (they are all independent so theoretically you could have a header that was indented as a child, and that had a "more" button on its right hand side). That's opposed to what java (currently) expects, "isGroup", "inGroup" or "isParent".

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 756107 [details] [diff] [review]
Patch v1

This is a sticky situation. In most cases, I don't expect devs to use, as opposed to the simple list. I'm in favor of simplifying though, but being able to get the right return value is even more important.

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1797dc46e862

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for robocop-2 failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b11bffd58de9

https://tbpl.mozilla.org/php/getParsedLog.php?id=23725149&tree=Mozilla-Inbound

Comment 5

[Wesley Johnston (:wesj)]

This was fine on try:

https://hg.mozilla.org/integration/mozilla-inbound/rev/950b81e80876

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/950b81e80876