877490 - Changing SIM cards should prompt the user to switch regions

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

We've been getting a lot of confusion about how we do region detection (e.g., bug 876386, bug 876404).

When a user changes his/her SIM card, we currently just change the carrier and pass that to the API. We originally assumed that the original region set is the user's true region - and that changing/adding a SIM should not change that region. But it's becoming apparent that users/QA/people are expecting the region to change upon changing SIM cards.

Instead of silently ignoring a new SIM card if we already have a region saved for that user, we should prompt the user to say that we detected a new SIM with a new region to browse apps in. I'd like to reuse the styles provided by Michael in https://bugzilla.mozilla.org/show_bug.cgi?id=780720

Comment 1

[Wil Clouser [:clouserw]]

I didn't think we could detect when a new SIM was inserted.  Can we?

Comment 2

[Christopher Van Wiemeersch [:cvan]]

(In reply to Wil Clouser [:clouserw] from comment #1)
> I didn't think we could detect when a new SIM was inserted.  Can we?

Yes: No SIM -> SIM
Yes: Old SIM -> New SIM
No: SIM -> No SIM

Comment 3

[Wil Clouser [:clouserw]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #2)
> (In reply to Wil Clouser [:clouserw] from comment #1)
> > I didn't think we could detect when a new SIM was inserted.  Can we?
> 
> Yes: No SIM -> SIM
> Yes: Old SIM -> New SIM
> No: SIM -> No SIM

Ah, thank you for the explanation.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/60b8968

Comment 5

[krupa raj[:krupa]]

I switched between movistar and t-mobile SIMS after clearing localstorage. However there was no prompt to change regions.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Krupa's Polish T-Mobile SIM card had an MCC-MNC pair of 260-021373417656, which isn't a recognised pair that we know. MNCs are always three digits, as far as I can tell, so I'm not sure what to make of this. I'm talking to Fabrice, etc.

Comment 7

[Christopher Van Wiemeersch [:cvan]]

So this works for SIMs with valid MCC-MNC pairs. But this won't be verifiable with a Polish SIM until bug 880369 is fixed. Feel free to try another SIM. But yeah.

Comment 8

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/3e4d491

Krupa, can you please try with a different SIM? Bug 880369 fixes the issues you encountered with your Polish SIM.

Comment 9

[krupa raj[:krupa]]

I filed a few bugs for alignment and inaccurate region detection. But the confirmation message is now in place.