Generate pref check code for interfaces with NoInterfaceObject, NavigatorProperty, and Pref/PrefEnabled

RESOLVED FIXED in mozilla24

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: reuben, Assigned: reuben)

Tracking

Trunk
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 755716 [details] [diff] [review]
Generate pref check code for interfaces with [NoInterfaceObject, NavigatorProperty]

Right now we only generate the pref check code for interfaces with interface objects.

This patch works, but is heavily cargo culted - I don't know if interfaces with a navigator property can be external or "workers". Should I move it the code into its own branch just for NavigatorProperty?
Attachment #755716 - Flags: review?(bzbarsky)
Comment on attachment 755716 [details] [diff] [review]
Generate pref check code for interfaces with [NoInterfaceObject, NavigatorProperty]

> I don't know if interfaces with a navigator property can be external or "workers"

So far, no.  External never, workers we;ll see.

This seems fine in general, but the parens are all wrong: we want parens around the (a or b) bit, not around the (c and d) bit.
Attachment #755716 - Flags: review?(bzbarsky) → review-
(Assignee)

Comment 2

5 years ago
Created attachment 755979 [details] [diff] [review]
Generate pref check code for interfaces with [NoInterfaceObject, NavigatorProperty], v1.1
Assignee: nobody → reuben.bmo
Attachment #755716 - Attachment is obsolete: true
Attachment #755979 - Flags: review?(bzbarsky)
Comment on attachment 755979 [details] [diff] [review]
Generate pref check code for interfaces with [NoInterfaceObject, NavigatorProperty], v1.1

r=me.  Thank you!
Attachment #755979 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/71bcb8b2a2da
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.