877501 - Generate pref check code for interfaces with NoInterfaceObject, NavigatorProperty, and Pref/PrefEnabled

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Reuben Morais [:reuben]]

Attachment: Generate pref check code for interfaces with [NoInterfaceObject, NavigatorProperty]

Right now we only generate the pref check code for interfaces with interface objects.

This patch works, but is heavily cargo culted - I don't know if interfaces with a navigator property can be external or "workers". Should I move it the code into its own branch just for NavigatorProperty?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 755716 [details] [diff] [review]
Generate pref check code for interfaces with [NoInterfaceObject, NavigatorProperty]

> I don't know if interfaces with a navigator property can be external or "workers"

So far, no.  External never, workers we;ll see.

This seems fine in general, but the parens are all wrong: we want parens around the (a or b) bit, not around the (c and d) bit.

Comment 2

[Reuben Morais [:reuben]]

Attachment: Generate pref check code for interfaces with [NoInterfaceObject, NavigatorProperty], v1.1

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 755979 [details] [diff] [review]
Generate pref check code for interfaces with [NoInterfaceObject, NavigatorProperty], v1.1

r=me.  Thank you!

Comment 4

[Reuben Morais [:reuben]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/71bcb8b2a2da

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/71bcb8b2a2da