Closed
Bug 877511
Opened 11 years ago
Closed 9 years ago
Remove ast/resources after building a locale
Categories
(L20n :: JS Library, defect, P4)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: zbraniecki, Unassigned)
References
Details
Attachments
(1 file)
|
516 bytes,
patch
|
stas
:
review+
|
Details | Diff | Splinter Review |
We currently store AST and resources loaded into memory forever. We probably can free that memory after we compiled a locale
|
Reporter | |
Comment 1•11 years ago
|
||
The difference on settings app: explicit: 9.76MB vs. 8.22MB RSS: 28.75MB vs. 27.02MB PSS: 19.12MB vs. 17.39MB VSB: 78.99MB vs. 80.18
Attachment #755723 -
Flags: review?(stas)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 755723 [details] [diff] [review] POC Review of attachment 755723 [details] [diff] [review]: ----------------------------------------------------------------- Looks like a simple change, r=me.
Attachment #755723 -
Flags: review?(stas) → review+
|
|
||
Updated•11 years ago
|
Priority: -- → P4
|
|
||
Comment 3•11 years ago
|
||
I came across an article about heap profiling with Chrome DevTools, pretty useful: https://developers.google.com/chrome-developer-tools/docs/heap-profiling Using the heap profiler I was able to confirm that the Resource objects get garbage collected with the patch.
|
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•