877519 - App 404 page is very uncool

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Rob Hudson [:robhudson]]

Attachment: scary 404

Go to an app that you know doesn't exist, like, say: https://marketplace-dev.allizom.org/app/omgwtfbbq

For a 404 page this is very scary looking.

The title says "Loading...".

The ratings API returns a 400 BAD REQUEST but the app API returned a 404. Not sure what that 400 is about.

Comment 1

[Davor Spasovski [:spasovski]]

Coolified! https://github.com/mozilla/fireplace/commit/eb0f551

Bonus points for a sexy 404 graphic to add here.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

This is/was totally a dupe of bug 870020, which Krupa rightly filed a month ago =)

Comment 3

[Rob Hudson [:robhudson]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #2)
> This is/was totally a dupe of bug 870020, which Krupa rightly filed a month
> ago =)

It's different in a subtle way, at least on the backend. This is from a 404, the other bug is from a 403. Looks way better btw. :)

Comment 4

[krupa raj[:krupa]]

We should say the page the user was looking for was not found. This page just loads with content missing which is confusing to users.

Comment 5

[Davor Spasovski [:spasovski]]

Basta fixed the error condition not triggering:

https://github.com/mozilla/fireplace/commit/94db0eb