Closed Bug 877565 Opened 11 years ago Closed 11 years ago

Pull #982 / bug 834942 broke tests on Firefox Mobile

Categories

(Add-on SDK Graveyard :: General, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: zer0, Assigned: jsantell)

References

()

Details

Attachments

(1 file)

It seems that the pull #982 was landed without test it on Fennec. The tests should be rewritten in order to be skipped in Fennec: if the module is not supported it should also add the proper `engines` property in module metadata.
Jordan, you made that pull as far as I can see. Do you mind to take a look to this bug?
Flags: needinfo?(jsantell)
Blocks: 854993
Assignee: nobody → jsantell
Flags: needinfo?(jsantell)
Depends on: 887999
Attached file GH Pull Request 1064
Favicon tests are now passing (skipped)
Attachment #768665 - Flags: review?(zer0)
Blocks: 787352
URL: 787352
Depends on: 890016
Bug 890016 supercedes this, making this redundant -- once 890016 lands, this will be completed
Attachment #768665 - Flags: review?(zer0)
890016 finished, making this redundant, closing
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: