Closed Bug 877616 Opened 6 years ago Closed 6 years ago

Attempting to drag a window via the title bar with a Persona enabled doesn't work

Categories

(Thunderbird :: Mail Window Front End, defect)

All
macOS
defect
Not set

Tracking

(thunderbird23 fixed, thunderbird24+ fixed)

RESOLVED FIXED
Thunderbird 24.0
Tracking Status
thunderbird23 --- fixed
thunderbird24 + fixed

People

(Reporter: standard8, Assigned: Paenglab)

Details

(Keywords: regression)

Attachments

(1 file)

When attempting to drag a window via the title bar, it doesn't work if Persona is enabled. It does work, if you drag via the toolbar.

Also, it does work if personas are disabled.
This is most likely caused by Bug 676241. This bug added OpenGL context to the titlebar, so we will need to handle dragging ourselves now like Firefox does (and how we handle dragging via the toolbar).

A regression range should be found that verifies that bug is the cause though.
Bug 676241 could make sense. As I wrote in bug 876710 it worked for me on 28. But not with the AB and Compozer.
I'll try this today Daily when I'm home. Maybe adding the padding-top to tabs-toolbar instead the window works also here (as a workaround until draw in titlebar lands).
Attached patch patchSplinter Review
Adding the padding-top to the tab-toolbar didn't work when mail.tabs.autoHide is true. I added the titlebar vbox now also to OS X like FX is doing. With the same rules as in FX it works now also on TB.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #756142 - Flags: ui-review?(mconley)
Attachment #756142 - Flags: review?(mconley)
Keywords: regression
Comment on attachment 756142 [details] [diff] [review]
patch

Review of attachment 756142 [details] [diff] [review]:
-----------------------------------------------------------------

What about the address book and compose windows? Don't we have to worry about those too?
This should be done in bug 876710.
Comment on attachment 756142 [details] [diff] [review]
patch

Review of attachment 756142 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, I see - I guess we don't need drag handles on those windows. I remember now.

Ok, yeah this looks fine to me. Thanks Richard!
Attachment #756142 - Flags: ui-review?(mconley)
Attachment #756142 - Flags: ui-review+
Attachment #756142 - Flags: review?(mconley)
Attachment #756142 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/a6fbfc1ce8c4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Comment on attachment 756142 [details] [diff] [review]
patch

[Triage Comment]
Leaping this forward onto Beta so we can get it fixed and tested earlier.
Attachment #756142 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.