Closed
Bug 877620
Opened 11 years ago
Closed 11 years ago
If there are no "Recent Closed tabs" disable the menu
Categories
(Thunderbird :: Toolbars and Tabs, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 24.0
People
(Reporter: Bogomil, Assigned: sshagarwal)
References
Details
(Keywords: ux-consistency, ux-natural-mapping, Whiteboard: [good first bug][mentor=mkmelin])
Attachments
(2 files, 3 obsolete files)
30.81 KB,
image/png
|
Details | |
2.32 KB,
patch
|
sshagarwal
:
review+
|
Details | Diff | Splinter Review |
If there are no "Recent Closed tabs" disable the menu or hide the arrow. Please see the screenshot
Reporter | ||
Updated•11 years ago
|
Keywords: ux-consistency,
ux-natural-mapping
Comment 1•11 years ago
|
||
Code pointers: goRecentlyClosedTabs: http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.xul#2642 InitGoMessagesMenu: http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.js#146 ... and then the same things for the appmenu.
OS: Linux → All
Hardware: x86 → All
Whiteboard: [good first bug][mentor=mkmelin]
Assignee | ||
Comment 2•11 years ago
|
||
Proposed patch using observer.
Assignee: nobody → syshagarwal
Status: NEW → ASSIGNED
Attachment #757133 -
Flags: feedback?(mkmelin+mozilla)
Attachment #757133 -
Flags: feedback?(acelists)
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
Fixing for both the go menus.
Attachment #757133 -
Attachment is obsolete: true
Attachment #757134 -
Attachment is obsolete: true
Attachment #757133 -
Flags: feedback?(mkmelin+mozilla)
Attachment #757133 -
Flags: feedback?(acelists)
Attachment #757135 -
Flags: feedback?(mkmelin+mozilla)
Attachment #757135 -
Flags: feedback?(acelists)
Comment on attachment 757135 [details] [diff] [review] Patch Review of attachment 757135 [details] [diff] [review]: ----------------------------------------------------------------- Looks good and works, thanks!
Attachment #757135 -
Flags: review?(mkmelin+mozilla)
Attachment #757135 -
Flags: feedback?(mkmelin+mozilla)
Attachment #757135 -
Flags: feedback?(acelists)
Attachment #757135 -
Flags: feedback+
Comment 6•11 years ago
|
||
Comment on attachment 757135 [details] [diff] [review] Patch Review of attachment 757135 [details] [diff] [review]: ----------------------------------------------------------------- Thx for the patch! r=mkmelin ::: mail/base/content/mailWindowOverlay.xul @@ +2638,5 @@ > recentAccessKey="&contextMoveCopyMsgRecentMenu.accesskey;"/> > </menu> > <menuseparator id="goFolderSeparator"/> > > + <menu id="goRecentlyClosedTabs" observes="cmd_undoCloseTab" nit: i'd put observes last after the other attributes, and at least on it's own line. (here and the other place)
Attachment #757135 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Fixed the nit. Carrying over review from mkmelin
Attachment #757135 -
Attachment is obsolete: true
Attachment #757661 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 8•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/1d440abb231f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in
before you can comment on or make changes to this bug.
Description
•