If there are no "Recent Closed tabs" disable the menu

RESOLVED FIXED in Thunderbird 24.0

Status

Thunderbird
Toolbars and Tabs
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Bogomil, Assigned: sshagarwal)

Tracking

({ux-consistency, ux-natural-mapping})

22 Branch
Thunderbird 24.0
ux-consistency, ux-natural-mapping

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=mkmelin])

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

4 years ago
Created attachment 755888 [details]
'Go' menu

If there are no "Recent Closed tabs" disable the menu or hide the arrow. Please see the screenshot
(Reporter)

Updated

4 years ago
Keywords: ux-consistency, ux-natural-mapping

Comment 1

4 years ago
Code pointers:

goRecentlyClosedTabs: http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.xul#2642

InitGoMessagesMenu: http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.js#146

... and then the same things for the appmenu.
OS: Linux → All
Hardware: x86 → All
Whiteboard: [good first bug][mentor=mkmelin]
(Assignee)

Comment 2

4 years ago
Created attachment 757133 [details] [diff] [review]
Patch

Proposed patch using observer.
Assignee: nobody → syshagarwal
Status: NEW → ASSIGNED
Attachment #757133 - Flags: feedback?(mkmelin+mozilla)
Attachment #757133 - Flags: feedback?(acelists)
(Assignee)

Comment 3

4 years ago
Created attachment 757134 [details] [diff] [review]
Patch
(Assignee)

Comment 4

4 years ago
Created attachment 757135 [details] [diff] [review]
Patch

Fixing for both the go menus.
Attachment #757133 - Attachment is obsolete: true
Attachment #757134 - Attachment is obsolete: true
Attachment #757133 - Flags: feedback?(mkmelin+mozilla)
Attachment #757133 - Flags: feedback?(acelists)
Attachment #757135 - Flags: feedback?(mkmelin+mozilla)
Attachment #757135 - Flags: feedback?(acelists)

Comment 5

4 years ago
Comment on attachment 757135 [details] [diff] [review]
Patch

Review of attachment 757135 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works, thanks!
Attachment #757135 - Flags: review?(mkmelin+mozilla)
Attachment #757135 - Flags: feedback?(mkmelin+mozilla)
Attachment #757135 - Flags: feedback?(acelists)
Attachment #757135 - Flags: feedback+

Comment 6

4 years ago
Comment on attachment 757135 [details] [diff] [review]
Patch

Review of attachment 757135 [details] [diff] [review]:
-----------------------------------------------------------------

Thx for the patch! r=mkmelin

::: mail/base/content/mailWindowOverlay.xul
@@ +2638,5 @@
>                         recentAccessKey="&contextMoveCopyMsgRecentMenu.accesskey;"/>
>            </menu>
>            <menuseparator id="goFolderSeparator"/>
>            
> +          <menu id="goRecentlyClosedTabs" observes="cmd_undoCloseTab"

nit: i'd put observes last after the other attributes, and at least on it's own line. (here and the other place)
Attachment #757135 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 7

4 years ago
Created attachment 757661 [details] [diff] [review]
Patch revised

Fixed the nit.
Carrying over review from mkmelin
Attachment #757135 - Attachment is obsolete: true
Attachment #757661 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/1d440abb231f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.